Feedback: polish AJAX fragment and adding PII scrub #2462
+434
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AJAX fragments had two minor flaws: * The English fragment contained pageData references that were missing from the French variant. That difference caused a hidden input named "contact" (with a JSON string as its value) to be injected into French feedback widgets. Although it didn't cause any other issues (data-feedback-link and data-feedback-url still worked fine in practice). * The no button's invisible transition message in JS mode is technically a status message, but wasn't coded as such (was using aria-live="polite" as opposed to role="status"). This resolves the flaws by: * Adding pageData references throughout the French fragment (same spots as English) to eliminate the hidden "contact" input. * Replacing aria-live="polite" with role="status" in the no button's transition message: * role="status" is a more formal way of denoting status messages, implicitly sets aria-live="polite" + aria-atomic="true" and is already in use for the widget's thank you message.
Garneauma
changed the title
|
Pre-approved upon successful review. |
duboisp
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Move in demoted folder.
Suggestion: Rename the file name to indicate this is a content fragment. Like "ajax-pft-v1" or something similar.
| @@ -1028,6 +1050,56 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "@id": "_:iteration_pft_1", | |||
There was a problem hiding this comment.
Is there a link to the demote ajax code example/sample?
duboisp
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Additional todo:
- Fix the confusion with the files in the "ajax" folder vs "asset" folder. Its seem there is some duplication.
- In the instruction, please mention that the implementer must upgrade their GCWeb installation to at least GCWeb v16.1.0 in order to use it.
|
@duboisp The "ajax" folder is for the "Report a problem" variation. The "assets" folder is for the "Page feedback tool" variation. There is no duplication. It was decided upon the introduction of the PFT that we would have the ajaxed-in file be in the "assets" folder since we have to copy that file to the AEM environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does the following:
1 - Polish AJAX fragments (from @EricDunsworth)
The AJAX fragments had two minor flaws:
This resolves the flaws by:
2 - Adds PII Scrub to the PFT
The Page feedback tool now has personal information screening added to the comment field on submit.
Supersedes #2401
Changes related to WET-509