Skip to content

Commit

Permalink
Feedback: adding PII Scrub to the PFT
Browse files Browse the repository at this point in the history
  • Loading branch information
@Garneauma
Garneauma committed Jan 13, 2025
1 parent add1764 commit ab7264f
Show file tree
Hide file tree
Showing 7 changed files with 114 additions and 20 deletions.
27 changes: 20 additions & 7 deletions _data/sites.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -645,10 +645,10 @@
"en": "Documentation on how to use the elements of the feedback area.",
"fr": "Documentation sur l'utilisation des éléments de la zone commentaires."
},
"modified": "2024-07-19",
"modified": "2025-01-09",
"componentName": "feedback",
"status": "stable",
"version": "2.1",
"version": "2.0.1",
"pages": {
"docs": [
{
Expand Down Expand Up @@ -729,10 +729,20 @@
},
"dependencies": {
"en": [
{ "title": "Page details", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-en.html", "component": "page-details" }
{ "title": "Page details", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-en.html", "component": "page-details" },
{ "title": "Postback", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-postback/wb-postback-en.html", "component": "postback" },
{ "title": "PII Scrub", "url": "https://wet-boew.github.io/wet-boew/docs/ref/pii-postback/pii-scrub-en.html", "component": "pii-scrub" },
{ "title": "Data JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-data-json/wb-data-json-en.html", "component": "wb-data-json" },
{ "title": "JSON Manager", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-jsonmanager/wb-jsonmanager-en.html", "component": "wb-json-manager" },
{ "title": "Do Action", "url": "https://wet-boew.github.io/GCWeb/components/wb-doaction/doaction-doc-en.html", "component": "doaction" }
],
"fr": [
{ "title": "Détails de la page", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-fr.html", "component": "page-details" }
{ "title": "Détails de la page", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-fr.html", "component": "page-details" },
{ "title": "Envoie de formulaire via Ajax", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-postback/wb-postback-fr.html", "component": "postback" },
{ "title": "Nettoyage d'IPI", "url": "https://wet-boew.github.io/wet-boew/docs/ref/pii-postback/pii-scrub-fr.html", "component": "pii-scrub" },
{ "title": "Data JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-data-json/wb-data-json-fr.html", "component": "wb-data-json" },
{ "title": "Gestionnaire JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-jsonmanager/wb-jsonmanager-fr.html", "component": "wb-json-manager" },
{ "title": "Do Action", "url": "https://wet-boew.github.io/GCWeb/components/wb-doaction/doaction-doc-fr.html", "component": "doaction" }
]
},
"a11yGuidance": "no accessibility guidance",
Expand Down Expand Up @@ -1024,10 +1034,12 @@
},
"notes": {
"en": [
"In order for your PFT to benefit from the personal information screening tool, you have to make sure your version of WET-BOEW is at 4.0.84 or higher.",
"To upgrade from the RAP to the PFT, follow the instructions of the \"Upgrade from RAP\" tab.",
"For more information about Data Ajax plugin, please visit <a href=\"https://wet-boew.github.io/wet-boew/docs/ref/data-ajax/data-ajax-en.html\">Data Ajax documentation page</a>."
],
"fr": [
"Pour que votre ORP puisse bénéficier de l'outil de filtrage des informations personnelles, vous devez vous assurer que votre version de WET-BOEW est supérieure ou égalse à 4.0.84.",
"Pour passer du SUP au ORP, suivez les instructions de l'onglet \"Mise à jour à partir de SUP\".",
"Pour plus d'informations sur le plugin Data Ajax, veuillez visiter la <a href=\"https://wet-boew.github.io/wet-boew/docs/ref/data-ajax/data-ajax-fr.html\">page de documentation Data Ajax</a>."
]
Expand Down Expand Up @@ -1615,12 +1627,13 @@
"iteration": [
{
"@id": "_:iteration_pft_2",
"name": "Page feedback tool - Iteration 1.1",
"date": "2024-07",
"name": "Page feedback tool - Iteration 2",
"date": "2025-01",
"detectableBy": "#gc-pft:has(.gc-pft-no p[role=\"status\"]:nth-of-type(2))",
"fixes": [
"AJAX fragment: Added <code>pageData</code> to the French variant",
"AJAX fragment: Changed <code>aria-live=\"polite\"</code> to <code>role=\"status\"</code> in \"Tell us why below:\"."
"AJAX fragment: Changed <code>aria-live=\"polite\"</code> to <code>role=\"status\"</code> in \"Tell us why below:\".",
"AJAX fragment: Added PII scrub of the comment field."
],
"predecessor": "_:iteration_pft_1",
"assets": [
Expand Down
12 changes: 12 additions & 0 deletions _data/templates.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1486,6 +1486,18 @@
"language": "fr",
"path": "topic-doc-fr.html"
}
],
"reports": [
{
"title": "Accessibility assessment #1 - GC topic template",
"language": "en",
"path": "reports/a11y-1-en.html"
},
{
"title": "Évaluation d'accessibilité #1 - Gabarits de page de sujet GC",
"language": "fr",
"path": "reports/a11y-1-fr.html"
}
]
},
"dependencies": {
Expand Down
32 changes: 30 additions & 2 deletions sites/feedback/assets/page-feedback-en.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,35 @@
<div class="col-sm-10 col-md-9 col-lg-8">
<section class="well mrgn-bttm-0">
<h3 class="wb-inv">Give feedback about this page</h3>
<form action="https://feedback-retroaction.canada.ca/api/QueueProblemForm" method="post" class="wb-postback wb-disable-allow" data-wb-postback='{"success":".gc-pft-thnk"}'>
<form action="https://feedback-retroaction.canada.ca/api/QueueProblemForm" method="post" class="wb-postback wb-disable-allow wb-pii-scrub" data-wb-postback='{"success":".gc-pft-thnk"}' data-wb-pii-scrub='{"modalTemplate": "[data-pft-scrub-modal]", "scrubChar": "########"}'>
<template data-pft-scrub-modal>
<header class="modal-header">
<h2 class="modal-title">Personal information in your comment has been removed</h2>
</header>
<div class="modal-body">
<p>Comments are only used to improve our website. You will not receive a response.</p>
<p><strong>To protect your privacy, your comment will be submitted as:</strong></p>
<div data-scrub-modal-fields=""></div>
<details class="mrgn-tp-md">
<summary>What is considered personal information?</summary>
<p>Certain types of information <strong>can’t</strong> be included in this comment form, such as your:</p>
<ul>
<li>email address</li>
<li>telephone number</li>
<li>postal code</li>
<li>passport number</li>
<li>business number</li>
<li>social insurance number (SIN)</li>
</ul>
</details>
</div>
<div class="modal-footer">
<div class="row">
<div class="col-xs-12 col-sm-6 mrgn-tp-sm"><button type="button" class="btn btn-link btn-block popup-modal-dismiss">Go back and edit comment</button></div>
<div class="col-xs-12 col-sm-6 mrgn-tp-sm"><button type="button" class="btn btn-primary btn-block popup-modal-dismiss" data-scrub-submit="">Submit comment</button></div>
</div>
</div>
</template>
<div class="wb-disable-allow" data-wb-json='{
"url": "#[gc-pft]/pageData",
"mapping": [
Expand Down Expand Up @@ -71,7 +99,7 @@ <h3 class="wb-inv">Give feedback about this page</h3>
<label id="gc-pft-prblm-label" for="gc-pft-prblm" class="mrgn-bttm-0"><span class="field-name">Please provide more details</span></label>
<p id="gc-pft-prblm-note" class="mrgn-bttm-sm"><small>You will not receive a reply. Don't include personal information (telephone, email, SIN, financial, medical, or work details).</small></p>
<p id="gc-pft-prblm-instruction" class="fnt-nrml small">Maximum 300 characters</p>
<textarea id="gc-pft-prblm" aria-describedby="gc-pft-prblm-note gc-pft-prblm-instruction" name="details" class="form-control full-width" maxlength="300"></textarea>
<textarea id="gc-pft-prblm" aria-describedby="gc-pft-prblm-note gc-pft-prblm-instruction" name="details" class="form-control full-width" maxlength="300" data-scrub-field></textarea>
</div>
<button name="helpful" value="No-Non" class="btn btn-primary">Submit</button>
</div>
Expand Down
32 changes: 30 additions & 2 deletions sites/feedback/assets/page-feedback-fr.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,35 @@
<div class="col-sm-10 col-md-9 col-lg-8">
<section class="well mrgn-bttm-0">
<h3 class="wb-inv">Donnez votre rétroaction sur cette page</h3>
<form action="https://feedback-retroaction.canada.ca/api/QueueProblemForm" method="post" class="wb-postback wb-disable-allow" data-wb-postback='{"success":".gc-pft-thnk"}'>
<form action="https://feedback-retroaction.canada.ca/api/QueueProblemForm" method="post" class="wb-postback wb-disable-allow wb-pii-scrub" data-wb-postback='{"success":".gc-pft-thnk"}' data-wb-pii-scrub='{"modalTemplate": "[data-pft-scrub-modal]", "scrubChar": "########"}'>
<template data-pft-scrub-modal>
<header class="modal-header">
<h2 class="modal-title">Les renseignements personnels dans votre commentaire ont été supprimés</h2>
</header>
<div class="modal-body">
<p>Les commentaires ne servent qu’à améliorer notre site Web. Vous ne recevrez aucune réponse.</p>
<p><strong>Afin de veiller à la protection de vos renseignements personnels, votre commentaire sera soumis comme suit&nbsp;:</strong></p>
<div data-scrub-modal-fields=""></div>
<details class="mrgn-tp-md">
<summary>Qu'est-ce qui est considéré comme un renseignement personnel?</summary>
<p>Certains renseignements <strong>ne peuvent pas</strong> être inclus dans ce formulaire de commentaire, notamment :</p>
<ul>
<li>Adresse courriel</li>
<li>Numéro de téléphone</li>
<li>Code postal</li>
<li>Numéro de passeport</li>
<li>Numéro d’entreprise</li>
<li>Numéro d’assurance sociale (NAS)</li>
</ul>
</details>
</div>
<div class="modal-footer">
<div class="row">
<div class="col-xs-12 col-sm-6 mrgn-tp-sm"><button type="button" class="btn btn-link btn-block popup-modal-dismiss">Revenir en arrière et modifier le commentaire</button></div>
<div class="col-xs-12 col-sm-6 mrgn-tp-sm"><button type="button" class="btn btn-primary btn-block popup-modal-dismiss" data-scrub-submit="">Soumettre le commentaire</button></div>
</div>
</div>
</template>
<div class="wb-disable-allow" data-wb-json='{
"url": "#[gc-pft]/pageData",
"mapping": [
Expand Down Expand Up @@ -71,7 +99,7 @@ <h3 class="wb-inv">Donnez votre rétroaction sur cette page</h3>
<label for="gc-pft-prblm" class="mrgn-bttm-0"><span class="field-name">Veuillez fournir plus de détails</span></label>
<p id="gc-pft-prblm-note" class="mrgn-bttm-sm"><small>Vous ne recevrez pas de réponse. N'incluez pas de renseignements personnels (téléphone, courriel, NAS, renseignements financiers, médicaux ou professionnels).</small></p>
<p id="gc-pft-prblm-instruction" class="fnt-nrml small">Maximum de 300 caractères</p>
<textarea id="gc-pft-prblm" aria-describedby="gc-pft-prblm-note gc-pft-prblm-instruction" name="details" class="form-control full-width" maxlength="300"></textarea>
<textarea id="gc-pft-prblm" aria-describedby="gc-pft-prblm-note gc-pft-prblm-instruction" name="details" class="form-control full-width" maxlength="300" data-scrub-field></textarea>
</div>
<button name="helpful" value="No-Non" class="btn btn-primary">Soumettre</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion sites/feedback/feedback-docs-en.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"title_section": "GCWeb (the Canada.ca theme in WET)",
"language": "en",
"altLangPage": "feedback-docs-fr.html",
"dateModified": "2023-11-08",
"dateModified": "2025-01-09",
"layout": "documentation",
"index_json": "index.json-ld",
"before_start_ajax_url": "dto-guidance-en.html #beforeYouBegin"
Expand Down
2 changes: 1 addition & 1 deletion sites/feedback/feedback-docs-fr.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"title_section": "GCWeb (le thème de Canada.ca dans la BOEW)",
"language": "fr",
"altLangPage": "feedback-docs-en.html",
"dateModified": "2023-11-08",
"dateModified": "2025-01-09",
"layout": "documentation",
"index_json": "index.json-ld",
"before_start_ajax_url": "dto-guidance-fr.html #beforeYouBegin"
Expand Down
27 changes: 20 additions & 7 deletions sites/feedback/index.json-ld
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
"en": "Documentation on how to use the elements of the feedback area.",
"fr": "Documentation sur l'utilisation des éléments de la zone commentaires."
},
"modified": "2024-07-19",
"modified": "2025-01-09",
"componentName": "feedback",
"status": "stable",
"version": "2.1",
"version": "2.0.1",
"pages": {
"docs": [
{
Expand Down Expand Up @@ -98,10 +98,20 @@
},
"dependencies": {
"en": [
{ "title": "Page details", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-en.html", "component": "page-details" }
{ "title": "Page details", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-en.html", "component": "page-details" },
{ "title": "Postback", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-postback/wb-postback-en.html", "component": "postback" },
{ "title": "PII Scrub", "url": "https://wet-boew.github.io/wet-boew/docs/ref/pii-postback/pii-scrub-en.html", "component": "pii-scrub" },
{ "title": "Data JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-data-json/wb-data-json-en.html", "component": "wb-data-json" },
{ "title": "JSON Manager", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-jsonmanager/wb-jsonmanager-en.html", "component": "wb-json-manager" },
{ "title": "Do Action", "url": "https://wet-boew.github.io/GCWeb/components/wb-doaction/doaction-doc-en.html", "component": "doaction" }
],
"fr": [
{ "title": "Détails de la page", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-fr.html", "component": "page-details" }
{ "title": "Détails de la page", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-fr.html", "component": "page-details" },
{ "title": "Envoie de formulaire via Ajax", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-postback/wb-postback-fr.html", "component": "postback" },
{ "title": "Nettoyage d'IPI", "url": "https://wet-boew.github.io/wet-boew/docs/ref/pii-postback/pii-scrub-fr.html", "component": "pii-scrub" },
{ "title": "Data JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-data-json/wb-data-json-fr.html", "component": "wb-data-json" },
{ "title": "Gestionnaire JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-jsonmanager/wb-jsonmanager-fr.html", "component": "wb-json-manager" },
{ "title": "Do Action", "url": "https://wet-boew.github.io/GCWeb/components/wb-doaction/doaction-doc-fr.html", "component": "doaction" }
]
},
"a11yGuidance": "no accessibility guidance",
Expand Down Expand Up @@ -393,10 +403,12 @@
},
"notes": {
"en": [
"In order for your PFT to benefit from the personal information screening tool, you have to make sure your version of WET-BOEW is at 4.0.84 or higher.",
"To upgrade from the RAP to the PFT, follow the instructions of the \"Upgrade from RAP\" tab.",
"For more information about Data Ajax plugin, please visit <a href=\"https://wet-boew.github.io/wet-boew/docs/ref/data-ajax/data-ajax-en.html\">Data Ajax documentation page</a>."
],
"fr": [
"Pour que votre ORP puisse bénéficier de l'outil de filtrage des informations personnelles, vous devez vous assurer que votre version de WET-BOEW est supérieure ou égalse à 4.0.84.",
"Pour passer du SUP au ORP, suivez les instructions de l'onglet \"Mise à jour à partir de SUP\".",
"Pour plus d'informations sur le plugin Data Ajax, veuillez visiter la <a href=\"https://wet-boew.github.io/wet-boew/docs/ref/data-ajax/data-ajax-fr.html\">page de documentation Data Ajax</a>."
]
Expand Down Expand Up @@ -984,12 +996,13 @@
"iteration": [
{
"@id": "_:iteration_pft_2",
"name": "Page feedback tool - Iteration 1.1",
"date": "2024-07",
"name": "Page feedback tool - Iteration 2",
"date": "2025-01",
"detectableBy": "#gc-pft:has(.gc-pft-no p[role=\"status\"]:nth-of-type(2))",
"fixes": [
"AJAX fragment: Added <code>pageData</code> to the French variant",
"AJAX fragment: Changed <code>aria-live=\"polite\"</code> to <code>role=\"status\"</code> in \"Tell us why below:\"."
"AJAX fragment: Changed <code>aria-live=\"polite\"</code> to <code>role=\"status\"</code> in \"Tell us why below:\".",
"AJAX fragment: Added PII scrub of the comment field."
],
"predecessor": "_:iteration_pft_1",
"assets": [
Expand Down

0 comments on commit ab7264f

Please sign in to comment.