Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM1 Property Package Re-Scaling #1530

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

MarcusHolly
Copy link
Contributor

Summary/Motivation:

Reworks how the ADM1 property package is scaled according to the new IDAES scaling routine

Changes proposed in this PR:

  • Updates ADM1 property package scaling
  • Updates the corresponding test files

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly added the Priority:Normal Normal Priority Issue or PR label Nov 22, 2024
@MarcusHolly MarcusHolly self-assigned this Nov 22, 2024
@@ -217,13 +218,53 @@ def release_state(self, flags, outlvl=idaeslog.NOTSET):
init_log.info("State Released.")


class ADM1_vaporPropertiesScaler(CustomScalerBase):
Copy link
Contributor Author

@MarcusHolly MarcusHolly Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not actually be usable since the vapor prop pack doesn't have a control volume. When testing this scaler in #1535 , I get the following error: AttributeError: '_ScalarADM1_vaporParameterBlock' object has no attribute 'temperature'. If this is true, we should probably just undo these changes to the vapor prop pack.

EDIT: I've undone these changes since it was causing issues with other flowsheets (properties not existing)

@MarcusHolly MarcusHolly marked this pull request as ready for review November 30, 2024 01:07
@MarcusHolly MarcusHolly marked this pull request as draft December 5, 2024 13:50
@MarcusHolly MarcusHolly marked this pull request as ready for review December 5, 2024 20:54
@ksbeattie ksbeattie added Priority:High High Priority Issue or PR and removed Priority:Normal Normal Priority Issue or PR labels Dec 5, 2024
Copy link
Contributor

@agarciadiego agarciadiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) December 13, 2024 14:41
@lbianchi-lbl lbianchi-lbl merged commit 93fc91d into watertap-org:main Dec 13, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDAES Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants