-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADM1 Property Package Re-Scaling #1530
ADM1 Property Package Re-Scaling #1530
Conversation
@@ -217,13 +218,53 @@ def release_state(self, flags, outlvl=idaeslog.NOTSET): | |||
init_log.info("State Released.") | |||
|
|||
|
|||
class ADM1_vaporPropertiesScaler(CustomScalerBase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not actually be usable since the vapor prop pack doesn't have a control volume. When testing this scaler in #1535 , I get the following error: AttributeError: '_ScalarADM1_vaporParameterBlock' object has no attribute 'temperature'
. If this is true, we should probably just undo these changes to the vapor prop pack.
EDIT: I've undone these changes since it was causing issues with other flowsheets (properties not existing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary/Motivation:
Reworks how the ADM1 property package is scaled according to the new IDAES scaling routine
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: