Implementation for CachedMeshContent #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses default Json instance now and moves custom serializer to Texture class. - All getters for cached content are synchronized. - Renamed classes to be consistent.
ppanopticon
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Looks good. I've made a few minor changes (some of which are not directly related to the PR).
Most importantly: You should minimize the number of custom Json { } serializer objects. In your implementation, every instance of CachedModel3dContent used its own instance, which can be a performance hit.
I have one final request: I would like to see a unit test that makes sure that serialization and deserialization works as expected. Test would look as follows:
- Load toy model
- Serializer
Model3d - De-serialize
Model3d - Check of two instances are identical.
If it simplifies things, the unit test can be added to the m3d module.
|
I have now added two unit tests to the m3d module.
|
|
Merged! Thank you :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the CachedMeshContent and solves issue #97.