Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Cached implementation for MeshContent #97

Closed
ppanopticon opened this issue Aug 19, 2024 · 0 comments · Fixed by #105
Closed

Missing Cached implementation for MeshContent #97

ppanopticon opened this issue Aug 19, 2024 · 0 comments · Fixed by #105
Assignees
@rahelarnold98
Labels
enhancement New feature or request
Milestone
Release Candidate #1

Comments

@ppanopticon
Copy link
Member

Task Description

Currently, there is now cached CachedContent implementation for Model3DContent. This should be added for the sake of consistency and completeness.

As a workaround, the CachedContentFactory currently returns an InMemoryMeshContent instance.
@ppanopticon ppanopticon added the enhancement New feature or request label Aug 19, 2024
@ppanopticon ppanopticon added this to the Release Candidate #1 milestone Aug 19, 2024
ppanopticon added a commit that referenced this issue Aug 19, 2024
@ppanopticon
Fixes a potential issue when trying to use CachedContentFactory with …
6311582 
…MeshContent. See #97 for issue tracking the absence of the proper implementation.

Signed-off-by: Ralph Gasser <[email protected]>
@lucaro lucaro mentioned this issue Aug 20, 2024
Merged
@rahelarnold98 rahelarnold98 mentioned this issue Aug 27, 2024
Merged
@rahelarnold98 rahelarnold98 linked a pull request Aug 27, 2024 that will close this issue
Implementation for CachedMeshContent #105
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahelarnold98 rahelarnold98

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release Candidate #1
Development

Successfully merging a pull request may close this issue.

Implementation for CachedMeshContent vitrivr/vitrivr-engine
2 participants
@ppanopticon @rahelarnold98