MikeTrahearn/1563 Show Popup for "Detect generator at AC input" setting #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeTrahearn-Qinetic
changed the title
MikeTrahearn-Qinetic
changed the title
MikeTrahearn-Qinetic
changed the title
|
This PR has been put on hold pending the outcome of #1818. |
MikeTrahearn-Qinetic
force-pushed
the
miketrahearn/1563-detect-generator-popup
branch
from
7b36e4a to
b4f5d6c
Compare
PageSettingsGenerator should correctly shows the existing toast by changing the enabled property to content.enabled so that the button may still be clickable. ListSwitch should be modified to emit its clicked() signal when the content.enabled is false. Fixes #1563
MikeTrahearn-Qinetic
force-pushed
the
miketrahearn/1563-detect-generator-popup
branch
from
b4f5d6c to
3c63eb2
Compare
| if (!generatorIsSet) { | ||
| //% "None of the AC inputs is set to generator. Go to the system setup page and set the correct AC input to generator in order to enable this functionality." | ||
| Global.showToastNotification(VenusOS.Notification_Info, qsTrId("page_settings_generator_detect_generator_not_set"), | ||
| Theme.animation_generator_detectGeneratorNotSet_toastNotification_autoClose_duration) | ||
| generatorACInputSwitch.toast = Global.showToastNotification(VenusOS.Notification_Info, qsTrId("page_settings_generator_detect_generator_not_set"), |
There was a problem hiding this comment.
add generatorACInputSwitch?.close() to close any existing toast immediately (because we can't recycle yet)
| } else { | ||
| //% "An alarm will be triggered when no power from the generator is detected at the inverter AC input. Make sure that the correct AC input is set to generator on the system setup page." | ||
| Global.showToastNotification(VenusOS.Notification_Info, qsTrId("page_settings_generator_detect_generator_set"), | ||
| Theme.animation_generator_detectGeneratorSet_toastNotification_autoClose_duration) | ||
| generatorACInputSwitch.toast = Global.showToastNotification(VenusOS.Notification_Info, qsTrId("page_settings_generator_detect_generator_set"), |
There was a problem hiding this comment.
add generatorACInputSwitch?.close() to close any existing toast immediately (because we can't recycle yet)
| @@ -124,7 +136,7 @@ Page { | |||
| if (!checked) { | |||
| //% "An alarm will be triggered when autostart function is left disabled for more than 10 minutes" | |||
| Global.notificationLayer.showToastNotification(VenusOS.Notification_Info, | |||
There was a problem hiding this comment.
review if we need to close any existing ToastNotification immediately (because we can't recycle yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PageSettingsGenerator should correctly shows the existing toast by changing the enabled property to content.enabled so that the button may still be clickable. ListSwitch should be modified to emit its clicked() signal when the content.enabled is false.
Fixes #1563