-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic Solution to disabled ListItems' Toast raising strategy #1818
Comments
Reviewing the following cases where ListSwitch uses onCheckedChanged rather than onClicked as a first step in this complex analysis; The following observations are made in the code when their onCheckedChanged is replaced with onClicked: ListChargeSchedule::ListSwitch::118
PageSettingsGsm::ListSwitch(delegate)::171
PageSettingsGsm::ListSwitch::197
PageSettingsHub4Peakshaving::ListSwitch::90
PageSettingsHub4Peakshaving::ListSwitch::131
DvccCommonSettings::ListSwitchForced::ListSwitch::20
|
Remove all superfluous ListPressArea and reconnect any dependent logic to the ListItem Part of #1818
Remove all superfluous ListPressArea and reconnect any dependent logic to the ListItem Part of #1818
Remove all superfluous ListPressArea and reconnect any dependent logic to the ListItem Part of #1818
Remove all superfluous ListPressArea and reconnect any dependent logic to the ListItem Part of #1818
Created #1876 as a generic issue for reworking the enabled/click handling in ListItem. |
Remove all superfluous ListPressArea and reconnect any dependent logic to the ListItem Part of #1818
Remove all superfluous ListPressArea and reconnect any dependent logic to the ListItem Part of #1818
Remove all superfluous ListPressArea and reconnect any dependent logic to the ListItem Part of #1818
Gui-v1 had a feature where ListItems such as MbSwitch would shadow the enabled property making it possible to implement a function where, while the ListItem would still be clickable even if the contained control e.g. switch) was disabled. In such a case a Toast would be shown indicating the reason why the control could not be changed.
This ticket to consider in more detail:
One such case is already documented here in PR 1814 which proposes one independent solution, but has been put on hold until this ticket resolves a more generic solution and a pattern that can be applied in all cases, having measured the scope of impact.
The text was updated successfully, but these errors were encountered: