Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: Add convenience list and count without Filter" #20879

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Revert "chore: Add convenience list and count without Filter" #20879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84ab5b4
Revert "chore: Add convenience list and count without Filter (#20867)"
Artur- Jan 19, 2025
8aa1da3
Update vaadin-spring/src/main/java/com/vaadin/flow/spring/data/CountS…
Artur- Jan 20, 2025
12399b4
Update CountService.java
Artur- Jan 20, 2025
d90b2ec
Merge branch 'main' into revert-20867-convenience-count-list
Artur- Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions vaadin-spring/src/main/java/com/vaadin/flow/spring/data/CountService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,6 @@
*/
public interface CountService {

/**
* Counts the number of items, without any filtering.
*
* @return the number of items in the service
*/
default long count() {
return count(null);
}

/**
* Counts the number of items that match the given filter.
*
Expand Down
12 changes: 0 additions & 12 deletions vaadin-spring/src/main/java/com/vaadin/flow/spring/data/ListService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,6 @@
* the type of object to list
*/
public interface ListService<T> {
/**
* Lists objects of the given type using the paging and sorting options
* provided in the parameters.
*
* @param pageable
* contains information about paging and sorting
* @return a list of objects or an empty list if no objects were found
*/
default List<T> list(Pageable pageable) {
return list(pageable, null);
}

/**
* Lists objects of the given type using the paging, sorting and filtering
* options provided in the parameters.
Expand Down
Loading