Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: Add convenience list and count without Filter" #20879

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jan 19, 2025

Reverts #20867

This causes problems with Hilla that does not support method overloading, as TS/JS does not support that

@Artur- Artur- requested a review from mshabarov January 19, 2025 07:41
Copy link

github-actions bot commented Jan 19, 2025

Test Results

1 165 files  ± 0  1 165 suites  ±0   1h 29m 52s ⏱️ + 2m 52s
7 625 tests ± 0  7 569 ✅ ± 0  56 💤 ±0  0 ❌ ±0 
7 970 runs  +12  7 907 ✅ +14  63 💤  - 2  0 ❌ ±0 

Results for commit d90b2ec. ± Comparison against base commit 0aac285.

♻️ This comment has been updated with latest results.

mshabarov
mshabarov previously approved these changes Jan 20, 2025
@Artur- Artur- requested a review from mshabarov January 20, 2025 07:27
@Artur- Artur- enabled auto-merge (squash) January 20, 2025 07:27
@Artur- Artur- merged commit 61f75cb into main Jan 20, 2025
25 of 26 checks passed
@Artur- Artur- deleted the revert-20867-convenience-count-list branch January 20, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants