Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(other): rollup #53

Closed
wants to merge 1 commit into from
Closed

fix(other): rollup #53

wants to merge 1 commit into from

Conversation

ulfgebhardt
Copy link
Member

@ulfgebhardt ulfgebhardt commented Nov 24, 2024

🍰 Pullrequest

fix rollup

actually include

  • node_modules
  • images
  • json

Remove all external dependencies except react as a peerDependency. It is not bundled with this package.

Issues

Todo

actually include
- node_modules
- images
- json

Remove all external dependencies except react as a peerDependency. It is
not bundled with this package.
@antontranelis
Copy link
Contributor

This fix causes a runtime error in utopia-map

Uncaught Error: Module "util" has been externalized for browser compatibility. Cannot access "util.__esModule" in client code.  See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.

ulfgebhardt added a commit to utopia-os/utopia-map that referenced this pull request Nov 24, 2024
This seems to be required by some packages now included into the rollup
bundle (utopia-os/utopia-ui#53).
As of
https://trycatchdebug.net/news/1129689/vite-build-error-textencoder the
polifill seems to be a good solution, removing errors from my build.
@antontranelis
Copy link
Contributor

antontranelis commented Nov 26, 2024

Utopia UI is supposed to be a mapping library that can easily integrated in other projects and would like to be as compatible as possible with other projects.

It would be better to find a solution that isn't requiring the host app to use a special polyfill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants