Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(other): separated types, eslint rule for importing types #52

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

ulfgebhardt
Copy link
Member

@ulfgebhardt ulfgebhardt commented Nov 24, 2024

🍰 Pullrequest

fix(other): separated types, eslint rule for importing types

  • Separated types and moved them into the proper ./types folder defined in the tsconfig.json.
  • Defined a new folder alias #types.
  • New eslint rule to enforce import type when a type is imported.
  • Removed Geometry Class and used manual Point types from geojson

Issues

Todo

  • None

- Separated types and moved them into the proper ./types folder defined
in the tsconfig.json.
- Defined a new folder alias `#types`.
- New eslint rule to enforce `import type` when a type is imported.
- Removed Geometry Class and used manual Point types from `geojson`
types should be included by typeRoots and hence not result in errors of
eslint (has to be monitored)
Copy link
Contributor

@antontranelis antontranelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine 👍

@antontranelis antontranelis merged commit 0b17cdb into main Nov 26, 2024
7 checks passed
@antontranelis antontranelis deleted the types branch November 26, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants