Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16: Start removing scope references #18074

Merged
merged 6 commits into from
Jan 22, 2025

Disable package validation, as this is a major

a9229d3
Select commit
Loading
Failed to load commit list.
Merged

v16: Start removing scope references #18074

Disable package validation, as this is a major
a9229d3
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v16/dev) succeeded Jan 22, 2025 in 38s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.26 (8.17 -> 8.43)

  • Improving Code Health: 4 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Constructor Over-Injection ContentValueSetValidator.cs: ContentValueSetValidator
  • Code Duplication ContentValueSetValidator.cs
  • Overall Code Complexity ContentValueSetValidator.cs
  • Primitive Obsession ContentValueSetValidator.cs

Annotations

Check notice on line 1 in src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v16/dev)

✅ No longer an issue: Code Duplication

The module no longer contains too many functions with similar structure

Check notice on line 1 in src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v16/dev)

✅ No longer an issue: Overall Code Complexity

The mean cyclomatic complexity in this module is no longer above the threshold

Check notice on line 1 in src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v16/dev)

✅ No longer an issue: Primitive Obsession

The ratio of primivite types in function arguments is no longer above the threshold

Check notice on line 42 in src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v16/dev)

✅ No longer an issue: Constructor Over-Injection

ContentValueSetValidator is no longer above the threshold for number of arguments. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.