Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v16: Start removing scope references #18074

Merged
merged 6 commits into from
Jan 22, 2025
Merged

v16: Start removing scope references #18074

merged 6 commits into from
Jan 22, 2025
+54 −46

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Jan 22, 2025

Fixes #12887

Notes

  • This will be the start of the working going into removing the obsolete IScopeProvider in Core, this has been obsolete for many years, and was slated to be removed in v14..

@Zeegaan Zeegaan requested a review from AndyButland January 22, 2025 12:47
AndyButland
AndyButland approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me (just a couple of tiny comments). I see the build is failing but doesn't seem related to this PR.

src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs Outdated Show resolved Hide resolved
src/Umbraco.Infrastructure/Examine/UmbracoIndexConfig.cs Outdated Show resolved Hide resolved
@Zeegaan Zeegaan merged commit 822a8cc into v16/dev Jan 22, 2025
27 checks passed
@Zeegaan Zeegaan deleted the v16/chore/start-removing-old-scope-references branch January 22, 2025 20:19
@Zeegaan Zeegaan mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyButland AndyButland AndyButland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeegaan @AndyButland