This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Warn about .pull-right or .pull-left within a navbar #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using W009 instead would fill the gap. |
|
W009 is in use in the code for the empty column lint. Needs to be documented on the wiki. |
|
Indeed! Documenting... |
dist/browser/bootlint.js
Outdated
| @@ -11095,6 +11104,12 @@ var LocationIndex = _location.LocationIndex; | |||
| reporter('Using `.pull-left` or `.pull-right` as part of the media object component is deprecated as of Bootstrap v3.3.0. Use `.media-left` or `.media-right` instead.', mediaPulls); | |||
| } | |||
| }); | |||
| addLinter("W011", function lintMediaPulls($, reporter) { | |||
There was a problem hiding this comment.
Function name needs changing
added 2 commits
April 6, 2015 14:55
Quick floats can be used within components that are within a navbar, but not on individual components. See this [comment](twbs#189 (comment)) Add brand to list and adjust test
Conflicts: dist/browser/bootlint.js src/bootlint.js
|
@zacechola: can you rebase and skip the dist file? |
|
Alternatively, @zacechola, you can enable |
|
Removing from v1.0.0 milestone since it is not necessary for supporting Bootstrap v4+. |
This was referenced Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this as W011, due to the similarity to W010. LMK if you feel differently.
Closes #188