This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
warn about outdated versions of Bootstrap #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvrebert
force-pushed
the
fix-163
branch
3 times, most recently
from
7d2d3bb to
30436d4
Compare
|
@hnrch02 Does this look good to you? |
|
Need to renumber this to |
| if (semver.lt(version, CURRENT_BOOTSTRAP_VERSION, true)) { | ||
| reporter(OUTDATED_BOOTSTRAP + version, elem); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Won't this cause trouble with plugins/addons/whatevers again?
There was a problem hiding this comment.
If their files are named something like foobar-bootstrap.css or /foobar/bootstrap.js, then yes.
Should be able to deal with the foobar-bootstrap.css cases by tweaking the selectors. Let me fix that...
|
Otherwise LGTM. |
once it's changed to
|
Changed the ID and fixed the edge case. Will merge once the Travis build succeeds. |
cvrebert
added a commit
that referenced
this pull request
Dec 16, 2014
warn about outdated versions of Bootstrap
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163.
To: @hnrch02 for review