Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix private member #refreshSessionPromise error #35

Merged
merged 5 commits into from
Jan 9, 2025
Merged

fix: fix private member #refreshSessionPromise error #35

merged 5 commits into from
Jan 9, 2025
+79 −62

Conversation

shuuji3
Copy link
Collaborator

@shuuji3 shuuji3 commented Jan 8, 2025

This PR is meant for proposing candidate to fix the issue on #32, and testing CI

@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for tsky canceled.

Name Link
🔨 Latest commit 54afc7a
🔍 Latest deploy log https://app.netlify.com/sites/tsky/deploys/677e98f8bbe9880008f63fa9

@shuuji3 shuuji3 marked this pull request as ready for review January 8, 2025 15:26
@shuuji3 shuuji3 mentioned this pull request Jan 8, 2025
Merged
@anbraten anbraten changed the base branch from main to atcute January 8, 2025 16:29
@shuuji3
Copy link
Collaborator Author

shuuji3 commented Jan 9, 2025 •
edited
Loading

I was able to move new XRPC() within Tsky.constructor() (https://github.com/tsky-dev/tsky/pull/35/files#diff-c5bb294c324c9abab152900812c05a2cb5f0b6ab4dfbc7b78e67ab28c0754822R11), so now Tsky's API is the same as the previous:

cf.

@shuuji3 shuuji3 force-pushed the fork/anbraten/atcute branch from a65f537 to c9c94e7 Compare January 9, 2025 09:03
@anbraten anbraten merged commit fcffd7b into tsky-dev:atcute Jan 9, 2025
1 check passed
@shuuji3 shuuji3 deleted the fork/anbraten/atcute branch January 9, 2025 09:54
@shuuji3 shuuji3 restored the fork/anbraten/atcute branch January 9, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuuji3 @anbraten