-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add client #32
feat: add client #32
Conversation
✅ Deploy Preview for tsky canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
.github/workflows/ci.yml
Outdated
env: | ||
ALICE_APP_PASSWORD: ${{ secrets.ALICE_PASSWORD }} | ||
BOB_APP_PASSWORD: ${{ secrets.BOB_PASSWORD }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I tried this branch in my fork repository: https://github.com/shuuji3/tsky/actions/runs/12554818190/job/35004050251?pr=1
I got a different error, but at least the current CI error (Secret is required
) can be fixed by setting the correct passwords in the repository setting. Could you double-check the repository setting and if there is correct secrets are set?
The secret names differ from the environment names, so I was a bit confused. To be consistent, maybe we can use the same name, ALICE_APP_PASSWORD
(not ALICE_PASSWORD
), for both the environment and GitHub secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we were able to solve the password issue. It seems that the secret value in GitHub Actions did not expand as we expected.
This CI log has the same error as the above link: https://github.com/tsky-dev/tsky/actions/runs/12635493640/job/35205727273?pr=32
I don't have any idea about why the private number access error occurs yet. Maybe we need to configure the test environment to use newer ECMAScript, or adjust the package importing of acute, or it can be TypeScript configuration issue? 🤔 (looks like those are not cases)
I somehow find a way to solve the current issue in #35. I tried changing to initialize I'm still unsure why the initial approach caused the issue, and if this approach is fine. Could you review my new commits? Feel free to cherry-pick here if you'd like. Side note during debugging:
|
Let's merge this one to unlock others to keep working on main directly, we can keep iterating there |
This is my approach to add some initial functions to the client.
For now it supports
tsky.bsky.profile()
,tsky.bsky.feed.getFeed()
andtsky.bsky.feed.getTimeline()
.In comparison to #22 it uses
@atcute/client
underneath to avoid implementing the session and error handling again.