-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TWE-13 - BE - Key points with icons (Service area page) #336
base: integration/2024-evolution
Are you sure you want to change the base?
TWE-13 - BE - Key points with icons (Service area page) #336
Conversation
12f59ba
to
e665d24
Compare
icon = "breadcrumb-expand" | ||
|
||
|
||
class IconKeyPointsBlock(blocks.StructBlock): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one doesn't seem to render properly for me, it's not picking up the template 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally didn't add in the icons yet because I wasn't sure if we were doing animated icons– which would require a different approach. I've confirmed with Ben that the icons won't be animated, so I've added them in now in e8ccfb5
Link to Ticket
Description of Changes Made
This ticket adds a new block for displaying key points (with icons) on the service area page.
FE styling will be a separate PR.
Note: There are some open questions on the ticket but I think they can be covered in the FE PR or in a separate PR.
How to Test
Screenshots
Service area page editor
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library