Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-13 - BE - Key points with icons (Service area page) #336

Open
wants to merge 6 commits into
base: integration/2024-evolution
Choose a base branch
from

Conversation

SharmaineLim
Copy link
Collaborator

@SharmaineLim SharmaineLim commented Jan 10, 2025

Link to Ticket

Description of Changes Made

This ticket adds a new block for displaying key points (with icons) on the service area page.

FE styling will be a separate PR.

Note: There are some open questions on the ticket but I think they can be covered in the FE PR or in a separate PR.

How to Test

  1. Create/Edit a service area page.
  2. Try to add a new block in the Body field. You should see "Key points with icons" as a block.
  3. Adding the "Key points with icons" block and filling in the required fields should display the new content on the preview.

Screenshots

Service area page editor

image

image

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@SharmaineLim SharmaineLim changed the base branch from main to feature/twe-11-service-area-page January 10, 2025 08:30
@SharmaineLim SharmaineLim marked this pull request as ready for review January 10, 2025 08:30
@zerolab zerolab mentioned this pull request Jan 10, 2025
31 tasks
Base automatically changed from feature/twe-11-service-area-page to integration/2024-evolution January 15, 2025 07:33
@SharmaineLim SharmaineLim force-pushed the feature/twe-13-keypoints-wicons branch from 12f59ba to e665d24 Compare January 15, 2025 07:52
icon = "breadcrumb-expand"


class IconKeyPointsBlock(blocks.StructBlock):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't seem to render properly for me, it's not picking up the template 🤔

Copy link
Collaborator Author

@SharmaineLim SharmaineLim Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally didn't add in the icons yet because I wasn't sure if we were doing animated icons– which would require a different approach. I've confirmed with Ben that the icons won't be animated, so I've added them in now in e8ccfb5

@shyusu4 shyusu4 mentioned this pull request Jan 21, 2025
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants