TWE-11 - BE - Service area page

[SharmaineLim]

Link to Ticket | Built on top of #324

Description of Changes Made

• Add the new Service area page BE, which reuses the existing block "Four photo collage block" from Division Page.
• Create the DivisionMixin which associates a page to a Division Page.
  • You can set the division to use within the Promote tab (if the field is made available in the page editor).
  • If the division field is not set, get the division from the closest ancestor that either:
    • has the division field populated, OR
    • the ancestor is a Division Page.
  • This mixin will be used later with pages like service pages, blog pages, etc.

I skipped making a stream_block_{page}.html (example) for this page because I'm not quite sure what the point of that is. It looks like an unnecessary extra step when I can access service_area_story_container.html directly.

How to Test

1. Add a child page to a division page
2. Create a service area page
3. Populate the fields and save

Screenshots

Service area page editor

Promote tab

MR Checklist

• Add a description of your pull request and instructions for the reviewer to verify your work.
• If your pull request is for a specific ticket, link to it in the description.
• Stay on point and keep it small so the merge request can be easily reviewed.
• Tests and linting passes.

Unit tests

• Added
  • in the form of a factory with a unit test + DivisionMixin tests
• Not required

Documentation

• Updated build docs
• Updated editor guidelines (See https://intranet.torchbox.com/torchbox-com-project-docs for the private link, for Torchbox employees only)
• Updated field spec (See https://intranet.torchbox.com/torchbox-com-project-docs for the private link, for Torchbox employees only)
• Not required

Browser testing

• I have tested in the following browsers and environments (edit the list as required)
  • Latest version of Chrome on mac
  • Latest version of Firefox on mac
  • Latest version of Safari on mac
  • Safari on last two versions of iOS
  • Chrome on last two versions of Android
• Not required

Data protection

• Not relevant
• This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

• I have tested the changes in both light and dark mode
• The change is not relevant to dark and light mode

Accessibility

• Automated WCAG 2.1 tests pass
• HTML validation passes
• Manual WCAG 2.1 tests completed
• I have tested in a screen reader
• I have tested in high-contrast mode
• Any animations removed for prefers-reduced-motion
• Not required

Sustainability

• Images are optimised and lazy-loading used where appropriate
• SVGs have been optimised
• Perfomance and transfer of data considered
• If JavaScript is needed alternatives have been considered
• Not required

Pattern library

• The pattern library component for this template displays correctly, and does not break parent templates
• The styleguide is updated if relevant
• Changes are not relevant the pattern library

[zerolab]

Most bits are straighforward so no complaints other than the missing promote_panel.

The two fundamental questions:

1. why not group division relevant content under its DivisionPage?
   • will there be content that is cross-division (or relevant to 2+ divisions)? if so, is the FK enough?
2. what is the difference between a service page and a service area page?

[zerolab]

I take it the icon + text block

is #336 ? and the service links block #337?

[SharmaineLim]

I take it the icon + text block

is #336 ? and the service links block #337?

@zerolab Yup!

[zerolab]

A few of more notes and I think it will be good to go