WIP: TCP issues #27
Open
WIP: TCP issues #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CUDA was already in master. * VAAPI is new. * Option to remove one conversion of framebuffer images. * Configuration is controlled with parameters in SDF configuration. Example configuration: models/ssrc_fog_x/ssrc_fog_x.sdf.jinja
It is better to have default configuration using software encoding and leave to the user to change it depending on which hardware is used.
This reverts commit b97b770.
GPS Plugin: ROS2 Service for Activation & Spoofing
Issues reported by running scripts/validate_sdf.bash script
Remove unused actions and create new ones using Dockerfiles: - Basic build test - Validate sdf
Prevents to flood the gazebo log with huge amount of "lat, lon" messages in case those are not needed.
…iving-in-separate-thread DP-2269 gazebo mavlink plugin receiving in separate thread
…able to correctly detects distance sensor in the simulation.
This change discards one of the warnings occuring during spawn of the drone.
Update of gazebo plugins for ssrc_fog_x model
Update simulation model dynamics
Previously used mavlink_parse_char() takes channel id to define static data buffer for parsing. These channels are global and shared with all mavlink plugin instances, so if they use the same channel id, they share the same memory buffer for message parsing => data corruption. Use mavlink_frame_char_buffer() instead to define local buffer for parsing.
Fix TCP receive message corruption
Mavlink message helper functions does not properly support multiple mavlink plugin instances, but the mavlink status is common for all instances causing message sequence numbers mixed up between PX4 instances. Every instance has now own mavlink status object and messages to be sent are finalized again with mavlink_finalize_message_buffer()function after encoding to fix the message sequence numbering.
fds_ was uninitialized when TCP is enabled. It's randomly non-zero and TCP connection never gets created.
ReadMAVLinkMessages() while-loop might get stuck permanently, which freezes all model updates. received_actuator_ never gets set.
This reverts commit f6e55b3. Temporarily reverted. Not working in kubernetes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.