-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades QuickJS to 2021-03-27, and support msvc and i686 targets #114
base: master
Are you sure you want to change the base?
Conversation
Hey. Thanks for this effort, supporting MSVC is very valuable!
Sadly the patch on the mailing list didn't get any response. I'm not comfortable with using a fork with so many significant changes as the default option since we would need to maintain and update it, and also thoroughly review it. What would be fine for me is providing the fork under a separate feature, like So the plan of action would be:
Bonus: update |
Hi. I'm all for providing the fork under an What do you think we add two git submodules? |
Hi @patr0nus I'm interessted in using this as an optional feature in my quickjs wrapper project (https://github.com/HiRoFa/quickjs_es_runtime) but i'm a bit concerned about future proofing it. You seem to be using your own branch of quickjs which is a fork a specific branch of a fork of quickjs (lyqstate/quickiot) When there is a new release of quickjs by bellard, how how much work would it be to update your branch? And are you planning/willing to keep your branch up to date or should i fork it mysqlf? Also, the i686 support means it should work on 32bits raspberry os right? |
I just ran into #66, which is an issue fixed by this patch. Just happened to pass by here and see this, so figured I'd mention it. |
This PR upgrades QuickJS to 2021-03-27, and adds supports for these targets:
x86_64-pc-windows-msvc
i686-pc-windows-msvc
i686-unknown-linux-gnu
What this PR does in detail:
That fork is originated from Improve cross platform comparability for quickjs. bellard/quickjs#49 and applied with the
js-tobigint64-overflow.patch
, so thepatch
feature is also no longer needed. I took the liberty of ignoringstack-overflow-signed.patch
since tests are passed without it any way. Please let me know if I missed anything.Also, if you are interested in merging this PR, please consider maintaining a separate QuickJS fork instead of using mine, as I am not really familiar with what the patches do.
build.rs
, because the generated bindings would be different between these newly-added targets.JSValue
as an opaque type. UseJS_VALUE_*
functions to read/write it, because theJSValue
is just an alias tou64
under i686 targets.