-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
32bit support / windows #45
Comments
get it working on 32bit raspbian and get the windows action on github working |
awaiting response at theduke/quickjs-rs#114 |
any movement about this one? |
Are you interested in 32bit or windows support? I solved my raspberry needs by using 64bit raspberryOS I'm not sure if quickjs supports windows nowadays, also the people at quickjs-ng seem to have some attention for that. I'l see what happens if i re-enable the windows tests, and between work and private matters i'm working on getting quickjs-ng working with this runtime.. |
i need windows support, i was checking other quick-js wrapper and i've found that quick-js doesn't work natively on windows but there are some patches for making it work. for example the lib DelSkayn/rquickjs support windows using the cargo patch command (there are .patch files in the project) and theduke/quickjs-rs support windows by building with the x86_64-pc-windows-gnu toolchain |
hi, I enabled the windows test and it seems to work... can you try building on windows? |
same error, the problem seams to be hirofa-quickjs-sys
and if i use the x86_64-pc-windows-gnu target i get
|
well, i know using msvc requires a lot of patching so that probably a no-go unstill projects like quickjs-ng fix it and we can use that mingw64 should work (as it does in my test) could you see what the windows test case does https://github.com/HiRoFa/quickjs_es_runtime/actions/runs/7811729245/job/21307353232 and spot any differences in path/executable compared to your output? I don't have a windows dev box so i can;'t be of the greatest help with this... |
ok, by looking at the logs i was able to figure it out.
|
Well, there's progress :) I updated some test code so the tests log to quickjs_runtime.log, could you update and rerun the tests with
Should give a better idea which test fails and why |
with this command cargo test -- --test-threads=1 the tests fails immediately and i get no logs
but running cargo test gave me the same result as the previous comment and also generated the .log file the file interrupts and gave no informations about the error. I'm running the tests on Windows 10 x64 with an AMD cpu and 16gb of ram EDIT: i'm probably blind... the problem seems to be "builder::tests::test_module_loader" EDIT2: i investigated a bit and found that everything's except modules works, every single module test failed |
and of course test_module_loader was one that did not init logging correctly yet :( i updated the code so that test case also logs to the log file, could you try again please? just |
hmm, it fails after compiling a module... I do a i may need to fall-back to the last 2023 release of quickjs.... -- edit -- |
please try again |
quickjs_runtime.log anyway if i remove the "import {foo} from 'some_module.mes';" part from the test it runs and ends without any issue |
There is a new version of quickjs-ng out which should provide support for compiling with msvc https://github.com/quickjs-ng/quickjs/releases/tag/v0.4.0 I'll have a look at making that work with ci but don't have a windows box to test beyond that... |
windows test fails with msvc, will look into this later
|
I've got issues with 32-bits which I cannot easily fix (I'm developing on a DE10-Nano which has a Cortex-A9 processor with 32-bits address space). I get a Segfault when trying to run the simple example from the docs. Is there anything I can help with to make this happen? QuickJS says they're supposed to support the processor. |
Hi @hansl Yes i've been unable to get anything working on 32bit (tried raspbian 32 bit and such) it does compile but the simplest api calls fail with segfaults... i have no idea why.. but also haven't looked to deep because i don't use 32 bits anymore. (also i don't know enough about rust-c interop to try any meaningful fixes..) In order to make this happen I guess we should start by compiling quickjs-sys on a 32 bit system and get a simple test case working.. also see if there is any difference when using quickjs-ng... |
|
No description provided.
The text was updated successfully, but these errors were encountered: