feat(styling): sheet styling refactor and light mode theme #200
Conversation
MangoFVTT
added
ui
There was a problem hiding this comment.
We should probably not actually merge these into the repo directly. At least not without putting these under a separate license.
There was a problem hiding this comment.
In that case we should prioritise swapping the theme over to the stormlight module and getting that running, otherwise we'll end up with a lot of unfinished stuff floating around
There was a problem hiding this comment.
Seconded!... Thirded?
Whatever, I agree ;)
There was a problem hiding this comment.
Seconded!... Thirded?
Whatever, I agree ;)
@zithith I can do that quite easily, will find some time today |
|
@stanavdb @zithith I've moved all Stormlight assets over to the handbook module in this PR: https://github.com/the-metalworks/stormlight-handbook/pull/13. Just the handbook for now, so that if we need to make changes to the theme I only do them in one place. Later on pre-release we can copy over all this stuff to the other modules so the theme can be registered from anywhere. |
…works#200) * Clean up part 1 * Add masks * Re-add content * Fix naming error * Add drop shadow style * Implement all fixed elements * Mostly finish details tab * Move all templates to preload * Implement search bar * Fix action list * Fix equipment list * Finish goals and equipment tab * Fix conditions * Fix adversary and dynamic boxes * Update to new fonts * Fix chat card dice totals * Adjust some colours and fonts * Organise assets * Rename texture * Add banners and texture * Fix alignment issue with new font * Fix chat card font issues * Fix light mode * Minor fixes * Remove Didact Gothic * Fix font variant issue * Default theme light mode colours * Update images and colours * Add some shadows for visibility * Add SC font to definitions * Fix path click bug * Remove robot * Rename all variables to avoid plotweaver confusion * Remove redundant list styling * Convert assets to webp * Move stormlight theme to handbook module
Type
What type of pull request is this? (e.g., Bug fix, Feature, Refactor, etc.)
Description
This is a giant PR that that completely refactors actor sheet CSS and fixes a host of issues with theming. In summary, this includes the following changes:
Related Issue
Closes #188, #47, #44.
How Has This Been Tested?
I've tested this and fixed a bunch of bugs already. There are more, for sure, since this is a major sheet refactor. I will continue to fix those bugs along the way as I proceed through styling.
Screenshots (if applicable)
Checklist:
Additional context
This is Part 1 of a major styling effort as we have discussed. I suspect this is the bulk of the work re: colouring and a lot of styling partials that can be re-used elsewhere, but there is plenty more work to come.