Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style character sheet #44

Closed
stanavdb opened this issue Sep 10, 2024 · 6 comments · Fixed by #200
Closed

Style character sheet #44

stanavdb opened this issue Sep 10, 2024 · 6 comments · Fixed by #200
Assignees
Labels
character sheet ui User interface related issue ux User experience related issue
Milestone

Comments

@stanavdb
Copy link
Collaborator

stanavdb commented Sep 10, 2024

The current design for the character sheet is functional, but doesn't yet match the awesome designs by @MangoFVTT.
The general structure is mostly there, but a lot of clean up on the CSS/HTML is needed.

Designs

01_SheetMockups_Details
02_SheetMockups_Actions
03_SheetMockups_Equipment
04_SheetMockups_Goals
05_SheetMockups_Effects

@stanavdb stanavdb added ui User interface related issue ux User experience related issue labels Sep 10, 2024
@PilotKayer
Copy link

I'll take care of it

@stanavdb
Copy link
Collaborator Author

Fair warning, the current CSS is an absolute mess. (entirely on me)

@stanavdb stanavdb assigned stanavdb and PilotKayer and unassigned stanavdb Oct 11, 2024
@zithith
Copy link
Collaborator

zithith commented Oct 11, 2024

Can we clarify this ticket to include theming and theme selection.
Leave the current style as base and just apply the stormlight bits as a theme (probably in a separate stylesheet so it can be ported out easily.
Think that is kinda implied in the code currently, but nice to add it to the description here

@stanavdb
Copy link
Collaborator Author

Can we clarify this ticket to include theming and theme selection. Leave the current style as base and just apply the stormlight bits as a theme (probably in a separate stylesheet so it can be ported out easily. Think that is kinda implied in the code currently, but nice to add it to the description here

Added.

@stanavdb
Copy link
Collaborator Author

On second thought, I have created a separate issue (#71) for theming so that #47 doesn't have to be dependent on this issue. I have made both this and #47 blocked by #71.

@PilotKayer Seeing as you're currently assigned to this, do you want me to assign you to #71 as well?

@stanavdb stanavdb added the blocked This issue is blocked by another issue label Oct 12, 2024
@PilotKayer PilotKayer mentioned this issue Oct 18, 2024
8 tasks
@TheFlyingPig
Copy link

Regarding theming, we should consider adding the option of transparency to the theme selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
character sheet ui User interface related issue ux User experience related issue
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants