Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MLPMixer test #154
base: main
Are you sure you want to change the base?
Add MLPMixer test #154
Changes from 2 commits
236e2ed
64ce76b
0cc94aa
297c2bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see,
MlpMixer.__call__
has only two paramsinputs, train
. Where did[weights, ins]
come from? Doesapply
use them?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The way flax linen works is that modules have an
apply
method that takes an argument calledvariables
(representing parameters, and possibly other state like batch statistics) alongside real model inputs, and then binds the state to where it needs to go and forwards inputs to__call__
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, got it. It is a bit weird that we cannot see
apply
's signature until we dig deeper, but okay. Maybe leave a comment that briefly explains howweights
andins
are passed throughapply
to__call__
.