Add MLPMixer test #154
Open
Add MLPMixer test #154
+188
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgligorijevicTT
requested review from
ajakovljevicTT,
kmitrovicTT and
mrakitaTT
as code owners
kmitrovicTT
reviewed
Jan 10, 2025
| # Alternatively, weights could be randomly initialized like this: | ||
| # weights = self._model.init(jax.random.PRNGKey(42), ins, train=False) | ||
|
|
||
| return [weights, ins] |
There was a problem hiding this comment.
As far as I can see, MlpMixer.__call__ has only two params inputs, train. Where did [weights, ins] come from? Does apply use them?
There was a problem hiding this comment.
Yes. The way flax linen works is that modules have an apply method that takes an argument called variables(representing parameters, and possibly other state like batch statistics) alongside real model inputs, and then binds the state to where it needs to go and forwards inputs to __call__.
There was a problem hiding this comment.
Yeah, got it. It is a bit weird that we cannot see apply's signature until we dig deeper, but okay. Maybe leave a comment that briefly explains how weights and ins are passed through apply to __call__.
kmitrovicTT
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.