[lower_to_mlir] Use named_attrs while lowering tt-forge ops to mlir #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgolubovicTT
requested review from
AleksKnezevic,
sdjordjevicTT and
vladimirjovanovicTT
dgolubovicTT
force-pushed
the
dgolubovic/named-attrs-in-lower-to-mlir
branch
from
5a9d443 to
dcbce09
Compare
…ng attributes for each op, while lowering to mlir.
dgolubovicTT
force-pushed
the
dgolubovic/named-attrs-in-lower-to-mlir
branch
from
dcbce09 to
8cc7c46
Compare
sdjordjevicTT
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #39. Use named_attrs from tt-forge ops instead of hardcoding attributes for each op, while lowering to mlir. This will enable easier lowering from tt-forge to MLIR without the need to know the exact attributes for each op. However, names of attributes in tt-forge ops have to be the same as in mlir.