FIX Stop using deprecated API #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Jan 6, 2025
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| namespace Symbiote\QueuedJobs\Jobs; | |||
|
|
|||
| use SilverStripe\Dev\Deprecation; | |||
GuySartorelli
commented
Jan 6, 2025
Comment on lines
-28
to
+30
| // Don't throw E_DEPRECATED in PHP 5.3+ | ||
| if (defined('E_DEPRECATED')) { | ||
| if ($errno == E_DEPRECATED || $errno == E_USER_DEPRECATED) { | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| switch ($errno) { | ||
| case E_DEPRECATED: | ||
| case E_USER_DEPRECATED: |
There was a problem hiding this comment.
Not really related but noticed it and seemed sensible to update this while I'm here, since E_DEPRECATED will always be defined in supported PHP versions now.
2 tasks
emteknetnz
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits here - feel free to squash if you want but can be left separate.
Issue