Remove deprecated code

[GuySartorelli]

There are a bunch of deprecations across the kitchen sink. We should remove that deprecated code.

Notes

• Not all deprecated code necessarily has a phpdoc with @deprecated annotation
• It's possible we added Deprecation::notice() but forgot to add a phpdoc - in that case make sure to add the phpdoc in CMS 5.

Acceptance Criteria

• All deprecated code is removed
• Comments with the word "deprecated" or "deprecation" are checked

PRs

I'm going to do a few rounds of this - the first round is things that are just no-brainers.

The second (and potentially subsequent) round is for anything that seems a bit more complicated, so that complex things can be reasoned about and considered and checked without having a spam of unrelated stuff in the same PRs.

Simple stuff

CMS 5

Some of the things being removed weren't correctly deprecated, but should still be removed. These PRs add the correct deprecations.

• API Deprecate API which will be removed in CMS 6 silverstripe-framework#11526
• DOC Document newly deprecated API developer-docs#662

After merging, reassign to Guy to merge-up to CMS 6

CMS 6

Kitchen sink CI run

• MNT Remove unused use statement for Deprecation silverstripe-subsites#623
• MNT Remove unused use statement for Deprecation silverstripe-versioned-admin#381
• MNT Remove unused use statement for Deprecation class silverstripe-elemental#1302
• FIX Stop using deprecated API silverstripe-frameworktest#221
• API Remove deprecated extension hooks silverstripe-admin#1880
• API Remove deprecated API silverstripe-assets#671
• API Remove deprecated API silverstripe-staticpublishqueue#212
• API Remove deprecated API silverstripe-framework#11524
• FIX Stop calling deprecated API silverstripe-lumberjack#182
• FIX Stop using deprecated API silverstripe-mimevalidator#85
• FIX Stop using deprecated API silverstripe-graphql#620
• API Remove deprecated API silverstripe-userforms#1361
• API Remove deprecated API silverstripe-versioned#484
• API Remove deprecated API silverstripe-cms#3042
• FIX Stop using deprecated API symbiote/silverstripe-queuedjobs#457
• DOC Remove references to removed API developer-docs#661

vendor-plugin deprecations

Note the supported modules json already (incorrectly) listed the 3 major release line as being the CMS 6 equivalents so that doesn't need to be updated.

Kitchen sink CI run

• API Remove deprecated API vendor-plugin#88
• DEP Update constraint for vendor-plugin dependency silverstripe-framework#11527
• DEP Update constraint for vendor-plugin silverstripe-installer#383
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-testsession#97
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-admin#1881
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-frameworktest#222
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-assets#672
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-reports#206
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-siteconfig#183
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-errorpage#130
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-graphql#621
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-versioned#485
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-versioned-admin#382
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-cms#3043
• DEP Don't include vendor-plugin as an explicit dependency symbiote/silverstripe-gridfieldextensions#424
• DEP Don't include vendor-plugin as an explicit dependency silverstripe-elemental#1303
• DEP Don't include vendor-plugin as an explicit dependency dnadesign/silverstripe-elemental-userforms#104
• DEP Don't include vendor-plugin as an explicit dependency tractorcow-farm/silverstripe-fluent#916
• DOC Update vendor-plugin version references developer-docs#663

i18n PRs

• FIX Finish removing deprecated i18n functionality. silverstripe-framework#11528
• DOC Remove references to sprintf in PHP i18n docs developer-docs#664

ArrayList case sensitivity

Kitchen Sink CI run

• ENH Align ArrayList case sensitivity with other lists silverstripe-framework#11529
• DOC Document change to ArrayList case sensitivity developer-docs#665

SearchContext $limit typing

CMS 5

• FIX Apply correct typing to $limit in BasicSearchContext silverstripe-framework#11535

After merging, reassign to Guy to merge up to CMS 6.

CMS 6

Kitchen Sink CI run

• API Add strong-typing to SearchContext::getQuery() $limit param silverstripe-framework#11534

DataObject::get() $join param

CMS 5

• API Deprecate API which will be removed in CMS 6 silverstripe-subsites#625
• DOC Document subsite deprecations developer-docs#666

After merging, reassign to Guy to merge up to CMS 6.

CMS 6

Kitchen Sink CI run

• API Remove deprecated parameter from DataObject::get() silverstripe-framework#11536
• API Remove deprecated $join parameters silverstripe-versioned#486
• FIX Don't use deprecated parameter silverstripe-cms#3044
• API Remove deprecated API silverstripe-subsites#624

TransactionManager

• DOC Remove "deprecated" note from PHPDoc for not-deprecated method silverstripe-framework#11537

getCMSValidator

CMS 5

• API Deprecate getCMSValidator() method. silverstripe-framework#11539

After merging, reassign to Guy to merge up to CMS 6.

CMS 6

Kitchen sink CI run

• API Stop supporting getCMSValidator silverstripe-framework#11538
• API Replace getCMSValidator with getCMSCompositeValidator silverstripe-frameworktest#223
• API Replace getCMSValidator with getCMSCompositeValidator silverstripe-userforms#1362
• API Replace getCMSValidator with updateCMSCompositeValidator symbiote/silverstripe-advancedworkflow#566
• DOC Remove reference to getCMSValidator in code comment silverstripe-admin#1882
• DOC Document stop supporting getCMSValidator() developer-docs#667

SearchableDropdownField setEmptyString()

• API Remove deprecation notice from method we're not removing silverstripe-framework#11540

"... for backwards compatibility"

I found various things which were kept or added purely for keeping BC with older versions. Some of them I just ignored because the effort required to sort out what would need to happen to remove the BC code wasn't worthwhile. But there are some where the BC code is just pure obvious tech debt and easy to remove - so those are dealt with here.

CMS 5

• API Deprecate passing bool to Form::loadDataFrom() silverstripe-framework#11542
• DOC Document deprecating boolean into Form::loadDataFrom() developer-docs#668

After merging, reassign to Guy to merge up to CMS 6.

CMS 6

Kitchen sink CI run

• ENH Remove code that had been retained for backwards compatibility silverstripe-framework#11541
• ENH Remove code that had been retained for backwards compatibility silverstripe-admin#1883
• ENH Remove code that had been retained for backwards compatibility silverstripe-behat-extension#294

Last set of changes

CMS 5

• A few deprecation fixes silverstripe-framework#11544

Note: The CMS 5 PR doesn't affect the CMS 6 PRs at all since the deprecated code isn't in framework anymore.

CMS 6

• DOC Remove note about deprecation from comment. silverstripe-admin#1885
• DOC Remove note about deprecation from comment. silverstripe-cms#3046
• MNT Remove unused use statement silverstripe-versioned#487
• ENH Remove unused properties and deprecation notices silverstripe-framework#11543
• API Remove old i18n template syntaxes silverstripe-template-engine#6
• DOC Document changes to template functionality developer-docs#669