Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sequencing): add a bouncer_weights serialization test for cende #3026

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

Yael-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@Yael-Starkware Yael-Starkware marked this pull request as ready for review December 30, 2024 15:14
Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @Yael-Starkware)


a discussion (no related file):
Is the serialization of the blockifier type the same as that of the Python?


crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects_test.rs line 57 at r1 (raw file):

pub const CENTRAL_DEPLOY_ACCOUNT_TX_JSON_PATH: &str = "central_deploy_account_tx.json";
pub const CENTRAL_DECLARE_TX_JSON_PATH: &str = "central_declare_tx.json";
pub const CENTRAL_L1_HANDLER_TX_JSON_PATH: &str = "central_l1_handler_tx.json";

I don't think you added the file

@Yael-Starkware Yael-Starkware force-pushed the yael/add_bouncer_weights_serialization branch from 000dec5 to d10483d Compare December 30, 2024 15:49
Copy link
Contributor Author

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)


crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects_test.rs line 57 at r1 (raw file):

Previously, DvirYo-starkware wrote…

I don't think you added the file

right, added now, done.

Copy link
Contributor Author

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)


a discussion (no related file):

Previously, DvirYo-starkware wrote…

Is the serialization of the blockifier type the same as that of the Python?

yes. it is just a struct of integers

Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@Yael-Starkware Yael-Starkware force-pushed the yael/central_l1_handler branch 2 times, most recently from 51cebef to ad67e29 Compare January 1, 2025 13:14
@Yael-Starkware Yael-Starkware force-pushed the yael/add_bouncer_weights_serialization branch from d10483d to 5fc76c9 Compare January 1, 2025 14:30
@Yael-Starkware Yael-Starkware force-pushed the yael/add_bouncer_weights_serialization branch from 5fc76c9 to a2cc251 Compare January 1, 2025 15:00
@Yael-Starkware Yael-Starkware changed the base branch from yael/central_l1_handler to main January 1, 2025 15:00
Copy link

github-actions bot commented Jan 1, 2025

Artifacts upload workflows:

Copy link

github-actions bot commented Jan 1, 2025

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [42.093 ms 43.976 ms 45.956 ms]
change: [-17.193% -10.540% -3.3205%] (p = 0.01 < 0.05)
Performance has improved.

Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@Yael-Starkware Yael-Starkware added this pull request to the merge queue Jan 1, 2025
Merged via the queue into main with commit 617b639 Jan 1, 2025
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants