Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sequencing): add cetral deploy account transaction written object #2872

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

Yael-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@Yael-Starkware Yael-Starkware marked this pull request as ready for review December 22, 2024 14:28
@Yael-Starkware Yael-Starkware force-pushed the yael/central_invoke_transaction branch 5 times, most recently from 2d58269 to 332d29e Compare December 24, 2024 07:23
@Yael-Starkware Yael-Starkware force-pushed the yael/central_deploy_account_transaction branch from aa9acdb to 46a6855 Compare December 24, 2024 07:23
@Yael-Starkware Yael-Starkware force-pushed the yael/central_invoke_transaction branch 4 times, most recently from f46b4b6 to 2fc1955 Compare December 25, 2024 14:41
@Yael-Starkware Yael-Starkware force-pushed the yael/central_deploy_account_transaction branch from 46a6855 to ccefd67 Compare December 25, 2024 15:03
Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r3, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @dafnamatsry)


-- commits line 2 at r3:
cooooooooooooooooooooooooooooooooooooooonesnsus.
The subject in general, should be sequencing and not consensus

Code quote:

coonsensus

@Yael-Starkware Yael-Starkware force-pushed the yael/central_deploy_account_transaction branch from ccefd67 to 933c9cc Compare December 26, 2024 13:58
@Yael-Starkware Yael-Starkware changed the base branch from yael/central_invoke_transaction to main December 26, 2024 13:58
@Yael-Starkware Yael-Starkware force-pushed the yael/central_deploy_account_transaction branch from 933c9cc to 67bf93b Compare December 26, 2024 14:04
@Yael-Starkware Yael-Starkware changed the title feat(coonsensus): add cetral deploy account transaction written object feat(consensus): add cetral deploy account transaction written object Dec 26, 2024
Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

@Yael-Starkware Yael-Starkware force-pushed the yael/central_deploy_account_transaction branch from 67bf93b to 5ee2f56 Compare December 29, 2024 11:56
@Yael-Starkware Yael-Starkware force-pushed the yael/central_deploy_account_transaction branch from 5ee2f56 to 66c8e37 Compare December 29, 2024 12:07
@Yael-Starkware Yael-Starkware changed the title feat(consensus): add cetral deploy account transaction written object feat(sequencing): add cetral deploy account transaction written object Dec 29, 2024
Copy link
Contributor Author

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @dafnamatsry)


-- commits line 2 at r3:

Previously, DvirYo-starkware wrote…

cooooooooooooooooooooooooooooooooooooooonesnsus.
The subject in general, should be sequencing and not consensus

done,

Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

@Yael-Starkware Yael-Starkware added this pull request to the merge queue Dec 29, 2024
Merged via the queue into main with commit 3653c49 Dec 29, 2024
15 of 26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants