Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blockifier): define alias compressor struct #2765

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Dec 18, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch 2 times, most recently from 923d08b to c25a813 Compare December 19, 2024 12:59
@yoavGrs yoavGrs force-pushed the yoav/compression/alias_compressor branch from ff8e757 to 3bf82ca Compare December 19, 2024 14:37
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from c25a813 to 47649ab Compare December 19, 2024 15:12
@yoavGrs yoavGrs force-pushed the yoav/compression/alias_compressor branch from 3bf82ca to ff60390 Compare December 19, 2024 15:12
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@yoavGrs yoavGrs force-pushed the yoav/compression/alias_compressor branch from ff60390 to ae7f69c Compare December 19, 2024 16:00
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@yoavGrs yoavGrs force-pushed the yoav/compression/alias_compressor branch from ae7f69c to e41ec4a Compare December 22, 2024 09:04
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware and @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from 47649ab to dd32d50 Compare December 23, 2024 08:22
@yoavGrs yoavGrs force-pushed the yoav/compression/alias_compressor branch from e41ec4a to cf2d3f0 Compare December 23, 2024 08:23
@yoavGrs yoavGrs force-pushed the yoav/aliasing/contract_address branch from dd32d50 to 7efd53f Compare December 23, 2024 09:07
@yoavGrs yoavGrs force-pushed the yoav/compression/alias_compressor branch 2 times, most recently from 01d697a to 7b96768 Compare December 23, 2024 09:30
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6, all commit messages.
Dismissed @graphite-app[bot] from 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@yoavGrs yoavGrs changed the base branch from yoav/aliasing/contract_address to graphite-base/2765 December 23, 2024 12:34
Copy link
Contributor Author

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

crates/blockifier/src/state/stateful_compression.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@yoavGrs yoavGrs force-pushed the yoav/compression/alias_compressor branch from 7b96768 to c781a55 Compare December 23, 2024 12:56
@yoavGrs yoavGrs changed the base branch from graphite-base/2765 to main December 23, 2024 12:56
@yoavGrs yoavGrs force-pushed the yoav/compression/alias_compressor branch from c781a55 to 44a7c63 Compare December 23, 2024 12:57
@yoavGrs yoavGrs removed the request for review from nimrod-starkware December 23, 2024 13:08
@yoavGrs yoavGrs merged commit 43c73ff into main Dec 23, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants