-
Notifications
You must be signed in to change notification settings - Fork 40.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AWS Advanced JDBC Wrapper #43812
base: main
Are you sure you want to change the base?
Conversation
This commit adds entry for AWS Advanced JDBC Wrapper to `DatabaseDriver` enum. See spring-projectsgh-31995 Signed-off-by: Vedran Pavic <[email protected]>
|
||
@Override | ||
protected Collection<String> getUrlPrefixes() { | ||
return List.of("aws-wrapper"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used List#of
as it seems to be the simplest option, but note that implementations of #getUrlPrefixes
in this enum are quite inconsistent - there are usages of Arrays#asList
and Collections#singleton
.
Perhaps this could be aligned in a separate issue to use List#of
consistently (first-timers-only
candidate?).
Thanks, @vpavic. In isolation, I wonder how useful this will be. Looking at how |
Thanks for the feedback. Motivation here is to simplify usage of AWS Advanced JDBC Wrapper by not having to specify I understand your concerns, and have refreshed my memory a bit on support for vendor-specific Flyway migrations (yes, I contributed that quite some while ago 🙂) and I believe your comment aims at this usage of Lines 391 to 392 in 269c761
This indeed doesn't play nice with wrapper drivers but such use cases could be updated to rely on database product name instead. I can contribute that if you agree with that direction. I can see that such approach is already used in Lines 139 to 141 in 269c761
In any case, I think these concerns are not new since Testcontainers JDBC driver also is of similar nature as it wraps the underlying JDBC driver and requires inserting its prefix into JDBC URL. |
This commit adds entry for AWS Advanced JDBC Wrapper to
DatabaseDriver
enum.See gh-31995