Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve JDBC driver class name for AWS drivers #31995

Closed
maciejwalkowiak opened this issue Aug 5, 2022 · 15 comments
Closed

Resolve JDBC driver class name for AWS drivers #31995

maciejwalkowiak opened this issue Aug 5, 2022 · 15 comments
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@maciejwalkowiak
Copy link
Contributor

Spring Boot could resolve JDBC driver class names for AWS variants of MySQL and PostgreSQL drivers:

If you believe this change makes sense, I would be happy to contribute a PR.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 5, 2022
@wilkinsona
Copy link
Member

Thanks for the suggestion, @maciejwalkowiak. This could be a nice addition, particularly for aws-mysql-jdbc. I think it may be better to wait for jdbc:postgresql:aws to stabilise before we add support for it. A PR that adds support for MySQL would be most welcome. Thanks.

@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 1, 2022
@wilkinsona wilkinsona added this to the 3.x milestone Sep 1, 2022
@maciejwalkowiak
Copy link
Contributor Author

I noticed few days ago there is a new JDBC driver related project from AWS in progress (https://github.com/awslabs/aws-advanced-jdbc-wrapper - 404 for now) - not sure if it only replaces Postgres driver or as the name suggests will cover more database types. Perhaps @susanmdouglas-aws or @marksailes can shine some light? So that we don't integrate driver that gets deprecated in upcoming months.

@wilkinsona
Copy link
Member

I'd noticed that yesterday and got the same 404 but hadn't taken the time to investigate. Thanks for doing that, @maciejwalkowiak. I agree that we should hold off until the role of the new JDBC driver becomes clear.

@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label Sep 2, 2022
@susanmdouglas-aws
Copy link

Hi - Can I recommend you reach out to @adalevinAWS for more information?

@adalevinAWS
Copy link

I'll update here once we have more information to share. I see you added the on-hold label for now, though. Thank you.

@vpavic
Copy link
Contributor

vpavic commented Nov 21, 2022

Release 1.0.0 of software.amazon.jdbc:aws-advanced-jdbc-wrapper (hosted on https://github.com/awslabs/aws-advanced-jdbc-wrapper) has apparently been published in early October.

With that in mind, maybe this could be revisited?

@wilkinsona
Copy link
Member

@adalevinAWS any updates on your side?

@vpavic
Copy link
Contributor

vpavic commented May 10, 2023

Since the last update here, AWS Advanced JDBC Driver project published a few releases (including the recent v2.0.0) and has generally been adding features valuable for users of Aurora-flavored DBs from AWS.

So it seems there aren't any reasons to keep this on-hold.

@wilkinsona
Copy link
Member

Given that the project seems to be quite well established, I guess we could assume that it's safe to proceed. I'd still welcome confirmation from @adalevinAWS though.

@hsuamz
Copy link

hsuamz commented May 10, 2023

Thanks @wilkinsona.

I'm from the team with the AWS drivers. We are focusing our efforts right now on the aws-advanced-jdbc-wrapper, in particular on certifying it for Aurora MySQL. We would welcome the PR for the aws-advanced-jdbc-wrapper.

Thank you.

@maciejwalkowiak
Copy link
Contributor Author

maciejwalkowiak commented May 11, 2023

@hsuamz any ETA for Aurora MySQL support?

@wilkinsona
Copy link
Member

Thanks, @hsuamz.

@wilkinsona wilkinsona removed the status: on-hold We can't start working on this issue yet label May 11, 2023
@davecramer
Copy link

@maciejwalkowiak There is (should be) no real difference between mysql and postgres as the driver "wraps" the underlying drivers. The existing driver is what will be released for mysql

vpavic added a commit to vpavic/spring-boot that referenced this issue Jan 14, 2025
This commit adds entry for AWS Advanced JDBC Wrapper to `DatabaseDriver`
enum.

See spring-projectsgh-31995

Signed-off-by: Vedran Pavic <[email protected]>
@vpavic
Copy link
Contributor

vpavic commented Jan 14, 2025

I've submitted a PR that attempts to resolve this - see #43812.

@wilkinsona
Copy link
Member

Closing in favor of #43812. Thanks for the PR, @vpavic.

@wilkinsona wilkinsona removed this from the 3.x milestone Jan 15, 2025
@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

8 participants