-
Notifications
You must be signed in to change notification settings - Fork 40.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve JDBC driver class name for AWS drivers #31995
Comments
Thanks for the suggestion, @maciejwalkowiak. This could be a nice addition, particularly for |
I noticed few days ago there is a new JDBC driver related project from AWS in progress (https://github.com/awslabs/aws-advanced-jdbc-wrapper - 404 for now) - not sure if it only replaces Postgres driver or as the name suggests will cover more database types. Perhaps @susanmdouglas-aws or @marksailes can shine some light? So that we don't integrate driver that gets deprecated in upcoming months. |
I'd noticed that yesterday and got the same 404 but hadn't taken the time to investigate. Thanks for doing that, @maciejwalkowiak. I agree that we should hold off until the role of the new JDBC driver becomes clear. |
Hi - Can I recommend you reach out to @adalevinAWS for more information? |
I'll update here once we have more information to share. I see you added the on-hold label for now, though. Thank you. |
Release With that in mind, maybe this could be revisited? |
@adalevinAWS any updates on your side? |
Since the last update here, AWS Advanced JDBC Driver project published a few releases (including the recent So it seems there aren't any reasons to keep this on-hold. |
Given that the project seems to be quite well established, I guess we could assume that it's safe to proceed. I'd still welcome confirmation from @adalevinAWS though. |
Thanks @wilkinsona. I'm from the team with the AWS drivers. We are focusing our efforts right now on the Thank you. |
@hsuamz any ETA for Aurora MySQL support? |
Thanks, @hsuamz. |
@maciejwalkowiak There is (should be) no real difference between mysql and postgres as the driver "wraps" the underlying drivers. The existing driver is what will be released for mysql |
This commit adds entry for AWS Advanced JDBC Wrapper to `DatabaseDriver` enum. See spring-projectsgh-31995 Signed-off-by: Vedran Pavic <[email protected]>
I've submitted a PR that attempts to resolve this - see #43812. |
Spring Boot could resolve JDBC driver class names for AWS variants of MySQL and PostgreSQL drivers:
jdbc:mysql:aws:
prefixjdbc:postgresql:aws:
prefixIf you believe this change makes sense, I would be happy to contribute a PR.
The text was updated successfully, but these errors were encountered: