-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amber Station Changes #34656
Merged
Emisse
merged 4 commits into
space-wizards:master
from
southbridge-fur:amber-station-changes
Jan 27, 2025
Merged
Amber Station Changes #34656
Emisse
merged 4 commits into
space-wizards:master
from
southbridge-fur:amber-station-changes
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains new or changed maps:
Maps are being rendered. This comment will be updated if rendering them is done. |
github-actions
bot
added
S: Untriaged
Status: Indicates an item has not been triaged and doesn't have appropriate labels.
size/L
Denotes a PR that changes 1000-4999 lines.
Changes: No C#
Changes: Requires no C# knowledge to review or fix this item.
Changes: Map
Changes: Might require knowledge of mapping.
S: Needs Review
Status: Requires additional reviews before being fully accepted
labels
Jan 26, 2025
This PR contains new or changed maps:
Maps are being rendered. This comment will be updated if rendering them is done. |
This PR contains new or changed maps:
Maps are being rendered. This comment will be updated if rendering them is done. |
ArtisticRoomba
added
P3: Standard
Priority: Default priority for repository items.
T: New Feature
Type: New feature or content, or extending existing content
D3: Low
Difficulty: Some codebase knowledge required.
A: Mapping
Area: Maps, or tools used for mapping
and removed
S: Untriaged
Status: Indicates an item has not been triaged and doesn't have appropriate labels.
labels
Jan 27, 2025
widgetbeck
pushed a commit
to widgetbeck/imp-station-14
that referenced
this pull request
Jan 29, 2025
* various changes * Increased player limit * slight modification * Followed proper yaml formatting, increased lawyers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A: Mapping
Area: Maps, or tools used for mapping
Changes: Map
Changes: Might require knowledge of mapping.
Changes: No C#
Changes: Requires no C# knowledge to review or fix this item.
D3: Low
Difficulty: Some codebase knowledge required.
P3: Standard
Priority: Default priority for repository items.
S: Needs Review
Status: Requires additional reviews before being fully accepted
size/L
Denotes a PR that changes 1000-4999 lines.
T: New Feature
Type: New feature or content, or extending existing content
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
maxPlayers
to 60 from 50Why / Balance
Implementing new features and also improving the map
When it comes to increasing the max player limit, I wanted to increase it largely because some of the other new maps that have come out have found that they work well at higher player limits, so I wanted to test that too. Also when I was looking into why the render was too large for github I overlayed other maps and realized Amber is actually pretty large and could totally support more players.
By my 6am calculator math there are a total of 63 job slots. So even with a full server not every job is going to get filled. This is also ignoring passengers, and I know some folks main passenger.
Technical details
Media
Map render is too big to post however there isn't much visually different
Requirements
Breaking changes
Changelog