Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conveyor optimisations #33870

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conveyor optimisations #33870

wants to merge 9 commits into from
+316 −91

Conversation

metalgearsloth
Copy link
Contributor

@metalgearsloth metalgearsloth commented Dec 15, 2024 •
edited
Loading

  • Optimise movement for moving stuff. Much better lookup flags + less resolves + slapped parallelrobustjob on it.
  • Avoids tracking contacts on its own.

Needs space-wizards/RobustToolbox#5560 + space-wizards/RobustToolbox#5440

Requires space-wizards/RobustToolbox#5637

I want to give it a shot using shapecasts which will also be a prototype for new mob movement similar to how most games handle it (outside of physics).

Current branch still needs subscribing to airtightchanges or whatever to know if we need to start re-conveying entities.

Resolves #33861

@metalgearsloth
Conveyor optimisations
1b2bde7 
- Optimise movement for moving stuff. Better flags + less resolves + slapped parallelrobustjob on it.
- Sleeping for entities getting conveyed into walls.
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/L Denotes a PR that changes 1000-4999 lines. labels Dec 15, 2024
@metalgearsloth metalgearsloth marked this pull request as ready for review December 21, 2024 22:50
@ScarKy0 ScarKy0 added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Performance Type: Performance impacting changes or bugs D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 24, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/L Denotes a PR that changes 1000-4999 lines. labels Jan 10, 2025
@ArtisticRoomba ArtisticRoomba removed the S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Performance Type: Performance impacting changes or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conveyors cause huge lag if there's a ton of items stuck on them
3 participants
@metalgearsloth @ScarKy0 @ArtisticRoomba