Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #16000 - add S3 support for eula PDF downloads #16090

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jan 17, 2025

This needs to be tested (and I'm having an issue on my local right now). This should fix #16000 though, enabled S3 downloads for EULA PDFs.

@snipe snipe changed the title Fixes #16000 - add S3 support for eula PDF downloads Fixed #16000 - add S3 support for eula PDF downloads Jan 17, 2025
Copy link

what-the-diff bot commented Jan 17, 2025

PR Summary

  • Introduction of Conditional Check for S3 Private Filesystem
    A new condition has been added for the S3 Private Filesystem configuration intending to generate a temporary URL. This will be used for downloading the EULA (End User License Agreement) PDF which increases the access security level.

  • Updating Method for S3 URL Redirection
    The method has been modified to redirect to the S3 URL if the filesystem is set to s3_private. This ensures efficient routing for data access and an enhanced user experience.

  • Maintaining Download Response for Local Storage
    Download responses for files stored locally are being maintained amidst changes to the file path handling to sustain data consistency in local storage use cases. This means users can still access their files with improved precision even if saved locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant