BUG: EULA PDFs are not downloadable with S3 support

[federicosilvestri]

The function getStoredEula does not use S3 to generate a valid URL for the EULA PDFs.

snipe-it/app/Http/Controllers/ActionlogController.php

Line 40 in 49918d3

public function getStoredEula($filename) : Response | BinaryFileResponse | RedirectResponse

I suggest to implement the function like this:

public function getStoredEula($filename) : Response | BinaryFileResponse | RedirectResponse
    {
        $this->authorize('view', \App\Models\Asset::class);
        $disk = config('filesystems.default');
        
        switch (config("filesystems.disks.$disk.driver")) {
            case 's3':
                $file = 'private_uploads/eula-pdfs/'.$filename;
                return redirect()->away(Storage::disk($disk)->temporaryUrl($file, now()->addMinutes(5)));
            default:
                $file = config('app.private_uploads').'/eula-pdfs/'.$filename;
                if (Storage::exists('private_uploads/eula-pdfs/'.$filename)) {
                    return response()->download($file);
                }
                return redirect()->back()->with('error',  trans('general.file_does_not_exist'));
        }

    }

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.