String validation always fails #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the interest in the project and putting this PR together. For some reason I wasn't seeing these PRS. This is very strange if this is true since we used this extensively at one of my old jobs and I feel like we would have ran into this. Let me take a few weeks to get back in the groove on this project again and I'll circle back on this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya, I know this project is probably unmaintained, but I'm finding it super useful. The string validator wasn't actually checking the value passed and always returned
false. Took me ages to figure out why all my sf objects created withmodel.new()were being created with the values "false".I'm not sure if there is another bug somewhere because the updates work and seem to use the same process.
I've tried to stick to your coding style but happy to make updates.