Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow optional empty #6

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Allow optional empty #6

merged 3 commits into from
Jul 31, 2024

Conversation

breenie
Copy link
Contributor

@breenie breenie commented Nov 29, 2023

Fields that are marked as not required fail validation if they are empty.

@skbolton
Copy link
Owner

Same comments as #5 (comment)

skbolton
skbolton approved these changes Jul 31, 2024
View reviewed changes
Copy link
Owner

@skbolton skbolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Will do a release after we get a few of these changes in

@skbolton skbolton merged commit c391aa1 into skbolton:master Jul 31, 2024
@breenie breenie deleted the allow-optional-empty branch July 31, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skbolton skbolton skbolton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breenie @skbolton