Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1035 add rotation id check for broadcast transaction #1042

Merged
merged 9 commits into from
Dec 15, 2023

Conversation

yavrsky
Copy link
Contributor

@yavrsky yavrsky commented Dec 1, 2023

No description provided.

@yavrsky yavrsky requested a review from olehnikolaiev December 1, 2023 12:10
@yavrsky yavrsky linked an issue Dec 1, 2023 that may be closed by this pull request
@yavrsky yavrsky linked an issue Dec 1, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f409b04) 95.40% compared to head (698548a) 95.40%.

Additional details and impacted files
@@           Coverage Diff            @@
##           v1.10.0    #1042   +/-   ##
========================================
  Coverage    95.40%   95.40%           
========================================
  Files           40       40           
  Lines         2850     2852    +2     
  Branches       670      671    +1     
========================================
+ Hits          2719     2721    +2     
  Misses         131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

olehnikolaiev
olehnikolaiev previously approved these changes Dec 1, 2023
Copy link
Contributor

@olehnikolaiev olehnikolaiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

DimaStebaev
DimaStebaev previously approved these changes Dec 1, 2023
@yavrsky yavrsky dismissed stale reviews from DimaStebaev and olehnikolaiev via 698548a December 15, 2023 10:51
@yavrsky yavrsky merged commit 65f4264 into v1.10.0 Dec 15, 2023
10 checks passed
@yavrsky yavrsky deleted the 1035-add-rotation_id-check-for-broadcast-transaction branch December 15, 2023 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add rotation_id check for broadcast transaction
3 participants