Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rotation_id check for broadcast transaction #1035

Closed
olehnikolaiev opened this issue Oct 18, 2023 · 5 comments · Fixed by #1042
Closed

add rotation_id check for broadcast transaction #1035

olehnikolaiev opened this issue Oct 18, 2023 · 5 comments · Fixed by #1042
Assignees
@yavrsky
Labels
epic:node-rotation
Milestone
SKALE 2.3

Comments

@olehnikolaiev
Copy link
Contributor

need to add this check to prevent a node sending broadcast transaction that does not belong to the current group
@olehnikolaiev olehnikolaiev added this to the SKALE 2.3 milestone Oct 18, 2023
@PolinaKiporenko PolinaKiporenko assigned yavrsky and unassigned payvint Oct 18, 2023
@PolinaKiporenko PolinaKiporenko moved this to Ready For Pickup in SKALE Engineering 🚀 Oct 18, 2023
@PolinaKiporenko
Copy link
Contributor

@payvint please add more details

@PolinaKiporenko
Copy link
Contributor

Related to https://github.com/skalenetwork/internal-support/issues/683

@PolinaKiporenko PolinaKiporenko moved this from Ready For Pickup to In Progress in SKALE Engineering 🚀 Nov 24, 2023
This was referenced Nov 29, 2023
Closed
Closed
@yavrsky yavrsky linked a pull request Dec 1, 2023 that will close this issue
1035 add rotation id check for broadcast transaction #1042
Merged
@yavrsky yavrsky removed a link to a pull request Dec 1, 2023
1035 add rotation id check for broadcast transaction #1042
Merged
@yavrsky yavrsky linked a pull request Dec 1, 2023 that will close this issue
1035 add rotation id check for broadcast transaction #1042
Merged
@PolinaKiporenko PolinaKiporenko moved this from In Progress to Code Review in SKALE Engineering 🚀 Dec 5, 2023
@DimaStebaev
Copy link
Contributor

Deploying of this change has to by synchronized with skale-admin update because the old version of skale-admin is not able to work with these changes.

@PolinaKiporenko PolinaKiporenko moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Dec 15, 2023
@DmytroNazarenko
Copy link
Contributor

skale-manager: 1.10.0-beta.0

@DmytroNazarenko DmytroNazarenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 Jan 18, 2024
@EvgeniyZZ EvgeniyZZ moved this from Merged To Release Candidate to QA in SKALE Engineering 🚀 Jan 23, 2024
@yatsunastya
Copy link

Checked ✅
admin: 2.6.0-beta.0
skale-manager: 1.10.0-beta.0

When node sends broadcast with incorrect rotation_id, transaction fails on dry run stage.

@EvgeniyZZ EvgeniyZZ moved this from QA to Done in SKALE Engineering 🚀 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yavrsky yavrsky

Labels
epic:node-rotation
Projects
SKALE Engineering 🚀
Archived in project
Milestone
SKALE 2.3
Development

Successfully merging a pull request may close this issue.

1035 add rotation id check for broadcast transaction skalenetwork/skale-manager
7 participants
@DimaStebaev @payvint @DmytroNazarenko @yavrsky @olehnikolaiev @PolinaKiporenko @yatsunastya