Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Сomplaint is sent to the wrong node #972

Closed
yatsunastya opened this issue Sep 4, 2023 · 4 comments
Closed

Сomplaint is sent to the wrong node #972

yatsunastya opened this issue Sep 4, 2023 · 4 comments
Assignees
Labels
bug Something isn't working epic:DKG need-to-retest
Milestone

Comments

@yatsunastya
Copy link

Precondition: #971
Describe the bug
Node sends complaint transaction to another node that has sent broadcast.

  1. Node ID 19 sends broadcast
  2. Node ID 16 receives 15 broadcasts
[2023-09-03 10:58:35,590 INFO][8][curly-red-alterf][T_1] - core.schains.dkg.utils:137 - sChain curly-red-alterf: total received 15 broadcasts from nodes [35, 9, 29, 15, 25, 31, 24, 16, 20, 23, 11, 17, 28, 19, 57]
  1. Node ID 16 sends complaint to Node ID 19
[2023-09-03 11:24:19,020 INFO][8][curly-red-alterf][T_1] - core.schains.dkg.client:326 - sChain: curly-red-alterf. 15 node is trying to sent a complaint on 0 node
[2023-09-03 11:25:06,461 INFO][8][curly-red-alterf][T_1] - skale.transactions.tools:60 - Estimated gas for complaint: 3750363
[2023-09-03 11:25:12,396 INFO][8][curly-red-alterf][T_1] - skale.transactions.tools:126 - Tx: complaint, Fields: {'chainId': 5, 'gas': 3750363, 'nonce': 297, 'value': 0, 'gasPrice': 10000000000, 'type': 1, 'to': '0x69E2C9576B36c8d7938Ba45a1C909B67EC53048E', 'data': '0xd76c2c4f000001fe6cdfae2691fe53493e697d4172434e71011784f660d5f407ffbb710000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000013'}, 
[2023-09-03 11:25:12,396 INFO][8][curly-red-alterf][T_1] - skale.wallets.redis_wallet:135 - Sending {'chainId': 5, 'gas': 3750363, 'nonce': 297, 'value': 0, 'gasPrice': 10000000000, 'type': 1, 'to': '0x69E2C9576B36c8d7938Ba45a1C909B67EC53048E', 'data': '0xd76c2c4f000001fe6cdfae2691fe53493e697d4172434e71011784f660d5f407ffbb710000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000013'} to redis pool, method: dkg.complaint
[2023-09-03 11:25:12,397 INFO][8][curly-red-alterf][T_1] - skale.wallets.redis_wallet:145 - Adding tx b'tx-6f5b4969ece90edc' to the pool
[2023-09-03 11:25:12,397 INFO][8][curly-red-alterf][T_1] - skale.wallets.redis_wallet:147 - Saving tx b'tx-6f5b4969ece90edc' record: b'{"status": "PROPOSED", "score": 51693740312, "multiplier": null, "tx_hash": null, "method": "dkg.complaint", "meta": null, "chainId": 5, "gas": null, "nonce": 297, "value": 0, "gasPrice": 10000000000, "type": 1, "to": "0x69E2C9576B36c8d7938Ba45a1C909B67EC53048E", "data": "0xd76c2c4f000001fe6cdfae2691fe53493e697d4172434e71011784f660d5f407ffbb710000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000013"}'

Admin: 2.5.1-develop.4
admin_dkg_log.txt

@olehnikolaiev
Copy link
Contributor

olehnikolaiev commented Nov 29, 2023

related to skalenetwork/skale-manager#1035. suggest to close or retest after the corresponding task will be completed

@PolinaKiporenko PolinaKiporenko moved this from To Do to Ready For Release Candidate in SKALE Engineering 🚀 Nov 29, 2023
@DmytroNazarenko
Copy link
Contributor

skale-admin: 2.6.0-beta.0
skale-manager: 1.10.0-beta.0

@DmytroNazarenko DmytroNazarenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 Jan 23, 2024
@EvgeniyZZ EvgeniyZZ moved this from Merged To Release Candidate to QA in SKALE Engineering 🚀 Jan 23, 2024
@yatsunastya
Copy link
Author

admin: 2.6.0-beta.0
skale-manager: 1.10.0-beta.0

The problem was reproduced again.

Node 9 sent Broadcast
Node 8 sent Complaint to Node 9.

But admin logs are rotated, so it's necessary to retest it one more time in order to confirm.

@yatsunastya
Copy link
Author

yatsunastya commented Feb 14, 2024

During testing this ticket, another bug was found with the same result.
So it's necessary to fix and check that bug, and only after that recheck this one.

@yatsunastya yatsunastya modified the milestones: SKALE 2.3, SKALE 2.4 Feb 14, 2024
@yatsunastya yatsunastya reopened this Feb 14, 2024
@github-project-automation github-project-automation bot moved this from QA to Ready For Pickup in SKALE Engineering 🚀 Feb 14, 2024
@PolinaKiporenko PolinaKiporenko modified the milestones: SKALE 2.4, SKALE 2.5 Apr 29, 2024
@DmytroNazarenko DmytroNazarenko modified the milestones: SKALE 2.5, SKALE 2.6 May 13, 2024
@EvgeniyZZ EvgeniyZZ moved this from Ready For Pickup to Done in SKALE Engineering 🚀 Aug 28, 2024
@github-project-automation github-project-automation bot moved this from Done to Ready For Release Candidate in SKALE Engineering 🚀 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epic:DKG need-to-retest
Projects
None yet
Development

No branches or pull requests

4 participants