API Deprecate API which will be removed in CMS 6 #11526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Jan 6, 2025
| @@ -1037,9 +1038,11 @@ public static function get_environment_type() | |||
| * @param HTTPRequest $request | |||
| * | |||
| * @return string|null null if not overridden, otherwise the actual value | |||
| * @deprecated 5.4.0 Use get_environment_type() instead. | |||
| */ | |||
| public static function get_session_environment_type(HTTPRequest $request = null) | |||
There was a problem hiding this comment.
See #11524 (comment)
Yes this is marked as @internal and we could technically remove it in 5.4, but it seems sensible to just deprecate and remove like we would with other public methods.
GuySartorelli
commented
Jan 6, 2025
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| /** | |||
| * Implements switching user session into Test and Dev environment types | |||
| * @deprecated 5.4.0 Will be removed without equivalent functionality to replace it. | |||
There was a problem hiding this comment.
See #11524 (comment)
2 tasks
emteknetnz
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of this was either incorrectly deprecated already or should have already been removed in CMS 5.
See comments in #11524
Issues