Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor edits to docs #370

Merged
merged 4 commits into from
Jan 24, 2025
Merged

docs: minor edits to docs #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94c92b0
minor edits to docs
trishankatdatadog Dec 27, 2024
b5588ff
Update verification.md
trishankatdatadog Dec 29, 2024
71209c7
Update verification.md
trishankatdatadog Dec 29, 2024
a50a773
Update signed_entity.go
trishankatdatadog Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/signing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This document will walk you through using `sigstore-go` to generate a Sigstore b
Clone this repository and run the following command:

```shell
$ make examples
$ make build-examples
$ go install ./examples/sigstore-go-signing
```

Expand Down
12 changes: 2 additions & 10 deletions docs/verification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,8 @@ Going through this step-by-step, we'll start by loading the trusted root from th
if err != nil {
panic(err)
}
trustedrootJSON, err := client.GetTarget("trusted_root.json")
if err != nil {
panic(err)
}

trustedMaterial, err := root.NewTrustedRootFromJSON(trustedrootJSON)
trustedMaterial, err := root.GetTrustedRoot(client)
if err != nil {
panic(err)
}
Expand Down Expand Up @@ -201,12 +197,8 @@ func main() {
if err != nil {
panic(err)
}
trustedrootJSON, err := client.GetTarget("trusted_root.json")
if err != nil {
panic(err)
}

trustedMaterial, err := root.NewTrustedRootFromJSON(trustedrootJSON)
trustedMaterial, err := root.GetTrustedRoot(client)
if err != nil {
panic(err)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/verify/signed_entity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ func WithCurrentTime() VerifierOption {
func (c *VerifierConfig) Validate() error {
if !c.requireObserverTimestamps && !c.requireSignedTimestamps && !c.requireIntegratedTimestamps && !c.useCurrentTime {
return errors.New("when initializing a new SignedEntityVerifier, you must specify at least one of " +
"WithObserverTimestamps(), WithSignedTimestamps(), WithIntegratedTimestamps(), or WithoutAnyObserverTimestampsUnsafe()")
"WithObserverTimestamps(), WithSignedTimestamps(), or WithIntegratedTimestamps()")
}

return nil
Expand Down
Loading