Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor edits to docs #370

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

trishankatdatadog
Copy link
Contributor

@trishankatdatadog trishankatdatadog commented Dec 27, 2024

Summary

Fix docs and/or code so that:

  1. The make command runs correctly.
  2. Getting the trusted root for verification is simpler.
  3. Verification error no longer refers to defunct (WithoutAnyObserverTimestampsUnsafe) option.

Release Note

NONE.

Documentation

This PR is self-documenting.

@trishankatdatadog trishankatdatadog requested a review from a team as a code owner December 27, 2024 15:57
Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
`WithoutAnyObserverTimestampsUnsafe` doesn't seem to exist anymore

Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
Copy link
Member

@steiza steiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is still in draft mode, but these changes LGTM. @trishankatdatadog was there anything else you wanted to put in here before taking this out of draft?

@haydentherapper haydentherapper marked this pull request as ready for review January 24, 2025 19:26
@haydentherapper haydentherapper merged commit 9c466a8 into sigstore:main Jan 24, 2025
11 checks passed
@trishankatdatadog
Copy link
Contributor Author

No, sorry for the late reply, and thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants