fix(sct_config): scylla-server-upgrade-target wasn't reported to Argus
#9638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruch
added
test-integration
`ARGUS_VERSION_RE` wasn't covering plain version like `6.3.0~dev` hence not sending it out to Argus. the change is fixing the regex this change also fixes `get_branch_version` to be able to return a full version string (including git sha and a date), cause we know Argus would need this data for metrics graphs and perf summaries. also not having this information, is casuing confusion on patch releases, when test are not get to the phase a node is upgrades Ref: scylladb/argus#533
fruch
force-pushed
the
fix_get_branch_version
branch
from
a32960c to
fb68806
Compare
I've found some issues with it, when testing it. had to refine the commands a bit more, and tested it also with manger repos |
soyacz
approved these changes
Jan 7, 2025
Now it works better and last upgrade test proven it |
This was referenced Jan 7, 2025
Merged
Merged
Merged
scylladbbot
added
backport/6.2-done
backport/2024.2-done
scylladbbot
added
backport/perf-v15-done
backport/perf-v16-done
and removed
backport/perf-v16
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARGUS_VERSION_REwasn't covering plain version like6.3.0~devhence not sending it out to Argus.the change is fixing the regex
this change also fixes
get_branch_versionto be able to return a full version string (including git sha and a date), cause we know Argus would need this data for metrics graphs and perf summaries.also not having this information, is causing confusion on patch releases, when test are not get to the phase a node is upgrades
Ref: scylladb/argus#533
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)