Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.0: Remove GAS in module execution flows #474

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Dec 25, 2022

This PR:

@mmv08 mmv08 requested a review from a team December 25, 2022 17:15
@coveralls
Copy link

coveralls commented Dec 25, 2022

Pull Request Test Coverage Report for Build 3882557761

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.943%

Totals Coverage Status
Change from base Build 3882044127: 0.0%
Covered Lines: 298
Relevant Lines: 306

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3776769989

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 98.056%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/base/Executor.sol 2 3 66.67%
Totals Coverage Status
Change from base Build 3775549655: -0.4%
Covered Lines: 307
Relevant Lines: 309

💛 - Coveralls

Copy link
Member

@rmeissner rmeissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not touch the Executor contract. We can call the execute method with type(uint256).max and get the same result without adding a new method and a constant.

@mmv08 mmv08 force-pushed the feat/remove-gasleft branch 2 times, most recently from ae8c0af to d3e3403 Compare December 28, 2022 21:25
@mmv08
Copy link
Member Author

mmv08 commented Dec 28, 2022

I would not touch the Executor contract. We can call the execute method with type(uint256).max and get the same result without adding a new method and a constant.

omg 🤦 🤦 for some reason the type max didn't compile the first time for me and I thought that it wasn't available in solidity 0.7.x. Thanks

@mmv08 mmv08 requested a review from rmeissner December 28, 2022 21:26
@mmv08 mmv08 force-pushed the feat/remove-gasleft branch from d3e3403 to 725a952 Compare January 10, 2023 10:44
@mmv08 mmv08 merged commit c2d0f04 into main Jan 10, 2023
@mmv08 mmv08 deleted the feat/remove-gasleft branch January 10, 2023 10:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants