Skip to content

Commit

Permalink
pass all available gas to execute in execTransactionFromModule
Browse files Browse the repository at this point in the history
  • Loading branch information
mmv08 committed Dec 28, 2022
1 parent 35040bf commit d3e3403
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions contracts/base/Executor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ import "../common/Enum.sol";
/// @title Executor - A contract that can execute transactions
/// @author Richard Meissner - <[email protected]>
contract Executor {
/// @dev Executes either a delegatecall or a call with provider parameters
/// @param to Destination address.
/// @param value Ether value.
/// @param data Data payload.
/// @param operation Operation type.
/// @return success boolean flag indicating if the call succeeded
function execute(
address to,
uint256 value,
Expand Down
2 changes: 1 addition & 1 deletion contracts/base/ModuleManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ contract ModuleManager is SelfAuthorized, Executor {
// Only whitelisted modules are allowed.
require(msg.sender != SENTINEL_MODULES && modules[msg.sender] != address(0), "GS104");
// Execute transaction without further confirmations.
success = execute(to, value, data, operation, gasleft());
success = execute(to, value, data, operation, type(uint256).max);
if (success) emit ExecutionFromModuleSuccess(msg.sender);
else emit ExecutionFromModuleFailure(msg.sender);
}
Expand Down

0 comments on commit d3e3403

Please sign in to comment.