perf: remove unchecked in for loop

.gas-snapshot

@@ -1,33 +1,33 @@
-Claim_Integration_Test:test_Claim() (gas: 278831)
-Claim_Integration_Test:test_RevertGiven_AlreadyClaimed() (gas: 266771)
-Claim_Integration_Test:test_RevertGiven_CampaignExpired() (gas: 17765)
-Claim_Integration_Test:test_RevertGiven_ProtocolFeeNotZero() (gas: 84689)
-Clawback_Integration_Test:testFuzz_Clawback(address) (runs: 20, μ: 316927, ~: 316927)
-Clawback_Integration_Test:testFuzz_Clawback_CampaignNotExpired(address) (runs: 20, μ: 88771, ~: 88771)
-Clawback_Integration_Test:test_Clawback() (gas: 272109)
-Clawback_Integration_Test:test_RevertGiven_CampaignNotExpired() (gas: 30440)
-Constructor_MerkleStreamerLL_Integration_Test:test_Constructor() (gas: 1219550)
-CreateMerkleStreamerLL_Integration_Test:testFuzz_CreateMerkleStreamerLL(address,uint40) (runs: 20, μ: 1139893, ~: 1139893)
-CreateMerkleStreamerLL_Integration_Test:test_RevertGiven_AlreadyDeployed() (gas: 8937393460516730625)
-CreateWithDeltas_Integration_Test:test_BatchCreateWithDeltas() (gas: 2070549)
-CreateWithDurations_Integration_Test:test_BatchCreateWithDurations() (gas: 1334021)
-CreateWithMilestones_Integration_Test:test_BatchCreateWithMilestones() (gas: 2063959)
-CreateWithRange_Integration_Test:test_CreateWithRange() (gas: 1336190)
-HasClaimed_Integration_Test:test_HasClaimed() (gas: 251894)
-HasClaimed_Integration_Test:test_HasClaimed_IndexNotInTree() (gas: 8011)
-HasClaimed_Integration_Test:test_HasClaimed_NotClaimed() (gas: 13268)
-HasExpired_Integration_Test:test_HasExpired_ExpirationEqualToCurrentTime() (gas: 13971)
-HasExpired_Integration_Test:test_HasExpired_ExpirationGreaterThanCurrentTime() (gas: 14065)
-HasExpired_Integration_Test:test_HasExpired_ExpirationLessThanCurrentTime() (gas: 5760)
-HasExpired_Integration_Test:test_HasExpired_ExpirationZero() (gas: 1081876)
+Claim_Integration_Test:test_Claim() (gas: 278641)
+Claim_Integration_Test:test_RevertGiven_AlreadyClaimed() (gas: 266327)
+Claim_Integration_Test:test_RevertGiven_CampaignExpired() (gas: 17745)
+Claim_Integration_Test:test_RevertGiven_ProtocolFeeNotZero() (gas: 84510)
+Clawback_Integration_Test:testFuzz_Clawback(address) (runs: 20, μ: 316725, ~: 316725)
+Clawback_Integration_Test:testFuzz_Clawback_CampaignNotExpired(address) (runs: 20, μ: 88746, ~: 88746)
+Clawback_Integration_Test:test_Clawback() (gas: 271907)
+Clawback_Integration_Test:test_RevertGiven_CampaignNotExpired() (gas: 30429)
+Constructor_MerkleStreamerLL_Integration_Test:test_Constructor() (gas: 1198502)
+CreateMerkleStreamerLL_Integration_Test:testFuzz_CreateMerkleStreamerLL(address,uint40) (runs: 20, μ: 1126334, ~: 1126334)
+CreateMerkleStreamerLL_Integration_Test:test_RevertGiven_AlreadyDeployed() (gas: 8937393460516730624)
+CreateWithDeltas_Integration_Test:test_BatchCreateWithDeltas() (gas: 2070068)
+CreateWithDurations_Integration_Test:test_BatchCreateWithDurations() (gas: 1333914)
+CreateWithMilestones_Integration_Test:test_BatchCreateWithMilestones() (gas: 2063258)
+CreateWithRange_Integration_Test:test_CreateWithRange() (gas: 1336083)
+HasClaimed_Integration_Test:test_HasClaimed() (gas: 251704)
+HasClaimed_Integration_Test:test_HasClaimed_IndexNotInTree() (gas: 7997)
+HasClaimed_Integration_Test:test_HasClaimed_NotClaimed() (gas: 13254)
+HasExpired_Integration_Test:test_HasExpired_ExpirationEqualToCurrentTime() (gas: 13957)
+HasExpired_Integration_Test:test_HasExpired_ExpirationGreaterThanCurrentTime() (gas: 14051)
+HasExpired_Integration_Test:test_HasExpired_ExpirationLessThanCurrentTime() (gas: 5746)
+HasExpired_Integration_Test:test_HasExpired_ExpirationZero() (gas: 1068623)
 MerkleBuilder_Test:testFuzz_ComputeLeaf(uint256,address,uint128) (runs: 20, μ: 1176, ~: 1176)
-MerkleBuilder_Test:testFuzz_ComputeLeaves((uint256,address,uint128)[]) (runs: 20, μ: 353773, ~: 397124)
-Precompiles_Test:test_DeployBatch() (gas: 2794484)
-Precompiles_Test:test_DeployMerkleStreamerFactory() (gas: 3124723)
-Precompiles_Test:test_DeployPeriphery() (gas: 5913539)
-USDC_CreateWithMilestones_Batch_Fork_Test:testForkFuzz_CreateWithMilestones((uint128,address,address,uint128,uint40,(uint128,uint64,uint40)[])) (runs: 20, μ: 34894028, ~: 21953046)
-USDC_CreateWithRange_Batch_Fork_Test:testForkFuzz_CreateWithRange((uint128,(uint40,uint40,uint40),address,address,uint128)) (runs: 20, μ: 1223264, ~: 1038250)
-USDC_MerkleStreamerLL_Fork_Test:testForkFuzz_MerkleStreamerLL((address,uint40,(uint256,uint256,uint128)[],uint256)) (runs: 20, μ: 4359652, ~: 3909187)
-USDT_CreateWithMilestones_Batch_Fork_Test:testForkFuzz_CreateWithMilestones((uint128,address,address,uint128,uint40,(uint128,uint64,uint40)[])) (runs: 20, μ: 34894028, ~: 21953046)
-USDT_CreateWithRange_Batch_Fork_Test:testForkFuzz_CreateWithRange((uint128,(uint40,uint40,uint40),address,address,uint128)) (runs: 20, μ: 1223264, ~: 1038250)
-USDT_MerkleStreamerLL_Fork_Test:testForkFuzz_MerkleStreamerLL((address,uint40,(uint256,uint256,uint128)[],uint256)) (runs: 20, μ: 4359652, ~: 3909187)
+MerkleBuilder_Test:testFuzz_ComputeLeaves((uint256,address,uint128)[]) (runs: 20, μ: 328702, ~: 368679)
+Precompiles_Test:test_DeployBatch() (gas: 2794084)
+Precompiles_Test:test_DeployMerkleStreamerFactory() (gas: 3098051)
+Precompiles_Test:test_DeployPeriphery() (gas: 5886439)
+USDC_CreateWithMilestones_Batch_Fork_Test:testForkFuzz_CreateWithMilestones((uint128,address,address,uint128,uint40,(uint128,uint64,uint40)[])) (runs: 20, μ: 35758280, ~: 21718385)
+USDC_CreateWithRange_Batch_Fork_Test:testForkFuzz_CreateWithRange((uint128,(uint40,uint40,uint40),address,address,uint128)) (runs: 20, μ: 1353143, ~: 1508161)
+USDC_MerkleStreamerLL_Fork_Test:testForkFuzz_MerkleStreamerLL((address,uint40,(uint256,uint256,uint128)[],uint256)) (runs: 20, μ: 4504409, ~: 3860802)
+USDT_CreateWithMilestones_Batch_Fork_Test:testForkFuzz_CreateWithMilestones((uint128,address,address,uint128,uint40,(uint128,uint64,uint40)[])) (runs: 20, μ: 35758280, ~: 21718385)
+USDT_CreateWithRange_Batch_Fork_Test:testForkFuzz_CreateWithRange((uint128,(uint40,uint40,uint40),address,address,uint128)) (runs: 20, μ: 1353143, ~: 1508161)
+USDT_MerkleStreamerLL_Fork_Test:testForkFuzz_MerkleStreamerLL((address,uint40,(uint256,uint256,uint128)[],uint256)) (runs: 20, μ: 4504409, ~: 3860802)

.github/workflows/multibuild.yml

@@ -21,6 +21,6 @@ jobs:
       - name: "Check that V2 Periphery can be built with multiple Solidity versions"
         uses: "PaulRBerg/foundry-multibuild@v1"
         with:
-          min: "0.8.19"
+          min: "0.8.22"
           max: "0.8.23"
           skip-test: "true"

.solhint.json

@@ -3,7 +3,7 @@
   "rules": {
     "avoid-low-level-calls": "off",
     "code-complexity": ["error", 8],
-    "compiler-version": ["error", ">=0.8.19"],
+    "compiler-version": ["error", ">=0.8.22"],
     "contract-name-camelcase": "off",
     "const-name-snakecase": "off",
     "custom-errors": "off",

script/Base.s.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { Script } from "forge-std/src/Script.sol";
 

script/CreateMerkleStreamerLL.s.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import { ISablierV2LockupLinear } from "@sablier/v2-core/src/interfaces/ISablierV2LockupLinear.sol";

script/DeployBatch.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { BaseScript } from "./Base.s.sol";
 

script/DeployDeterministicBatch.s.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { BaseScript } from "./Base.s.sol";
 

script/DeployDeterministicPeriphery.s.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { BaseScript } from "./Base.s.sol";
 

script/DeployMerkleStreamerFactory.s.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { BaseScript } from "./Base.s.sol";
 

script/DeployPeriphery.s.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { BaseScript } from "./Base.s.sol";
 

script/DeployProtocol.s.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { SablierV2Comptroller } from "@sablier/v2-core/src/SablierV2Comptroller.sol";
 import { SablierV2LockupDynamic } from "@sablier/v2-core/src/SablierV2LockupDynamic.sol";

src/SablierV2Batch.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19;
+pragma solidity >=0.8.22;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import { SafeERC20 } from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
@@ -40,10 +40,9 @@ contract SablierV2Batch is ISablierV2Batch {
         // transactions will revert if there is overflow.
         uint256 i;
         uint256 transferAmount;
-        for (i = 0; i < batchSize;) {
+        for (i = 0; i < batchSize; ++i) {
             unchecked {
                 transferAmount += batch[i].totalAmount;
-                i += 1;
             }
         }
 
@@ -52,7 +51,7 @@ contract SablierV2Batch is ISablierV2Batch {
 
         // Create a stream for each element in the parameter array.
         streamIds = new uint256[](batchSize);
-        for (i = 0; i < batchSize;) {
+        for (i = 0; i < batchSize; ++i) {
             // Create the stream.
             streamIds[i] = lockupLinear.createWithDurations(
                 LockupLinear.CreateWithDurations({
@@ -66,11 +65,6 @@ contract SablierV2Batch is ISablierV2Batch {
                     transferable: batch[i].transferable
                 })
             );
-
-            // Increment the for loop iterator.
-            unchecked {
-                i += 1;
-            }
         }
     }
 
@@ -94,10 +88,9 @@ contract SablierV2Batch is ISablierV2Batch {
         // transactions will revert if there is overflow.
         uint256 i;
         uint256 transferAmount;
-        for (i = 0; i < batchSize;) {
+        for (i = 0; i < batchSize; ++i) {
             unchecked {
                 transferAmount += batch[i].totalAmount;
-                i += 1;
             }
         }
 
@@ -106,7 +99,7 @@ contract SablierV2Batch is ISablierV2Batch {
 
         // Create a stream for each element in the parameter array.
         streamIds = new uint256[](batchSize);
-        for (i = 0; i < batchSize;) {
+        for (i = 0; i < batchSize; ++i) {
             // Create the stream.
             streamIds[i] = lockupLinear.createWithRange(
                 LockupLinear.CreateWithRange({
@@ -120,11 +113,6 @@ contract SablierV2Batch is ISablierV2Batch {
                     transferable: batch[i].transferable
                 })
             );
-
-            // Increment the for loop iterator.
-            unchecked {
-                i += 1;
-            }
         }
     }
 
@@ -152,10 +140,9 @@ contract SablierV2Batch is ISablierV2Batch {
         // transactions will revert if there is overflow.
         uint256 i;
         uint256 transferAmount;
-        for (i = 0; i < batchSize;) {
+        for (i = 0; i < batchSize; ++i) {
             unchecked {
                 transferAmount += batch[i].totalAmount;
-                i += 1;
             }
         }
 
@@ -164,7 +151,7 @@ contract SablierV2Batch is ISablierV2Batch {
 
         // Create a stream for each element in the parameter array.
         streamIds = new uint256[](batchSize);
-        for (i = 0; i < batchSize;) {
+        for (i = 0; i < batchSize; ++i) {
             // Create the stream.
             streamIds[i] = lockupDynamic.createWithDeltas(
                 LockupDynamic.CreateWithDeltas({
@@ -178,11 +165,6 @@ contract SablierV2Batch is ISablierV2Batch {
                     transferable: batch[i].transferable
                 })
             );
-
-            // Increment the for loop iterator.
-            unchecked {
-                i += 1;
-            }
         }
     }
 
@@ -206,10 +188,9 @@ contract SablierV2Batch is ISablierV2Batch {
         // transactions will revert if there is overflow.
         uint256 i;
         uint256 transferAmount;
-        for (i = 0; i < batchSize;) {
+        for (i = 0; i < batchSize; ++i) {
             unchecked {
                 transferAmount += batch[i].totalAmount;
-                i += 1;
             }
         }
 
@@ -218,7 +199,7 @@ contract SablierV2Batch is ISablierV2Batch {
 
         // Create a stream for each element in the parameter array.
         streamIds = new uint256[](batchSize);
-        for (i = 0; i < batchSize;) {
+        for (i = 0; i < batchSize; ++i) {
             // Create the stream.
             streamIds[i] = lockupDynamic.createWithMilestones(
                 LockupDynamic.CreateWithMilestones({
@@ -233,11 +214,6 @@ contract SablierV2Batch is ISablierV2Batch {
                     transferable: batch[i].transferable
                 })
             );
-
-            // Increment the for loop iterator.
-            unchecked {
-                i += 1;
-            }
         }
     }
 

src/SablierV2MerkleStreamerFactory.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19;
+pragma solidity >=0.8.22;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import { ISablierV2LockupLinear } from "@sablier/v2-core/src/interfaces/ISablierV2LockupLinear.sol";

src/SablierV2MerkleStreamerLL.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19;
+pragma solidity >=0.8.22;
 
 import { BitMaps } from "@openzeppelin/contracts/utils/structs/BitMaps.sol";
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";

src/abstracts/SablierV2MerkleStreamer.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19;
+pragma solidity >=0.8.22;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import { SafeERC20 } from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";

src/interfaces/ISablierV2Batch.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19;
+pragma solidity >=0.8.22;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import { ISablierV2LockupDynamic } from "@sablier/v2-core/src/interfaces/ISablierV2LockupDynamic.sol";

src/interfaces/ISablierV2MerkleStreamer.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19;
+pragma solidity >=0.8.22;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import { IAdminable } from "@sablier/v2-core/src/interfaces/IAdminable.sol";

src/interfaces/ISablierV2MerkleStreamerFactory.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19;
+pragma solidity >=0.8.22;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import { ISablierV2LockupLinear } from "@sablier/v2-core/src/interfaces/ISablierV2LockupLinear.sol";

src/interfaces/ISablierV2MerkleStreamerLL.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19;
+pragma solidity >=0.8.22;
 
 import { ISablierV2LockupLinear } from "@sablier/v2-core/src/interfaces/ISablierV2LockupLinear.sol";
 

src/libraries/Errors.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19;
+pragma solidity >=0.8.22;
 
 /// @title Errors
 /// @notice Library containing all custom errors the protocol may revert with.

src/types/DataTypes.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
-pragma solidity >=0.8.19;
+pragma solidity >=0.8.22;
 
 import { ISablierV2Lockup } from "@sablier/v2-core/src/interfaces/ISablierV2Lockup.sol";
 import { Broker, LockupDynamic, LockupLinear } from "@sablier/v2-core/src/types/DataTypes.sol";

test/Base.t.sol

@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: UNLICENSED
 // solhint-disable max-states-count
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { ERC20 } from "@openzeppelin/contracts/token/ERC20/ERC20.sol";
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";

test/fork/Fork.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: UNLICENSED
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import { ISablierV2LockupDynamic } from "@sablier/v2-core/src/interfaces/ISablierV2LockupDynamic.sol";

test/fork/assets/USDC.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: UNLICENSED
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 

test/fork/assets/USDT.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: UNLICENSED
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 

test/fork/batch/createWithMilestones.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: UNLICENSED
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import { LockupDynamic } from "@sablier/v2-core/src/types/DataTypes.sol";

test/fork/batch/createWithRange.t.sol

@@ -1,5 +1,5 @@
     // SPDX-License-Identifier: UNLICENSED
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import { LockupLinear } from "@sablier/v2-core/src/types/DataTypes.sol";

test/fork/merkle-streamer/MerkleStreamerLL.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: UNLICENSED
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { Arrays } from "@openzeppelin/contracts/utils/Arrays.sol";
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";

test/integration/Integration.t.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: UNLICENSED
-pragma solidity >=0.8.19 <0.9.0;
+pragma solidity >=0.8.22 <0.9.0;
 
 import { Precompiles as V2CorePrecompiles } from "@sablier/v2-core/test/utils/Precompiles.sol";